From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.garry@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
jejb@linux.vnet.ibm.com, linuxarm@huawei.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ming Lei <ming.lei@redhat.com>,
chenxiang <chenxiang66@hisilicon.com>
Subject: Re: [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch
Date: Thu, 11 Oct 2018 03:15:34 -0700 [thread overview]
Message-ID: <20181011101534.GA31802@infradead.org> (raw)
In-Reply-To: <118d01db-05f4-a85b-850c-c4e5a5616a16@huawei.com>
On Thu, Oct 11, 2018 at 10:59:11AM +0100, John Garry wrote:
>
> > blk-mq tags are always per-host (which has actually caused problems for
> > ATA, which is now using its own per-device tags).
> >
>
> So, for example, if Scsi_host.can_queue = 2048 and Scsi_host.nr_hw_queues =
> 16, then rq tags are still in range [0, 2048) for that HBA, i.e. invariant
> on queue count?
Yes, if can_queue is 2048 you will gets tags from 0..2047.
IFF you device needs different tags for different queues it can use
the blk_mq_unique_tag heper to generate unique global tag.
But unless you actuall have multiple hardware queues that latter part
is rather irrelevant to start with.
next prev parent reply other threads:[~2018-10-11 10:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 15:06 [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch John Garry
2018-09-24 15:06 ` [PATCH 1/7] scsi: hisi_sas: Feed back linkrate(max/min) when re-attached John Garry
2018-09-24 15:06 ` [PATCH 2/7] scsi: hisi_sas: Move evaluation of hisi_hba in hisi_sas_task_prep() John Garry
2018-09-24 15:06 ` [PATCH 3/7] scsi: hisi_sas: Fix the race between IO completion and timeout for SMP/internal IO John Garry
2018-09-24 15:06 ` [PATCH 4/7] scsi: hisi_sas: Free slot later in slot_complete_vx_hw() John Garry
2018-09-24 15:06 ` [PATCH 5/7] scsi: hisi_sas: unmask interrupts ent72 and ent74 John Garry
2018-09-24 15:06 ` [PATCH 6/7] scsi: hisi_sas: Use block layer tag instead for IPTT John Garry
2018-09-24 15:06 ` [PATCH 7/7] scsi: hisi_sas: Update v3 hw AIP_LIMIT and CFG_AGING_TIME register values John Garry
2018-10-04 15:30 ` [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch John Garry
2018-10-11 1:58 ` Martin K. Petersen
2018-10-11 6:36 ` Christoph Hellwig
2018-10-11 9:59 ` John Garry
2018-10-11 10:15 ` Christoph Hellwig [this message]
2018-10-11 13:12 ` John Garry
2018-10-11 13:32 ` Ming Lei
2018-10-11 14:07 ` John Garry
2018-10-11 23:36 ` Ming Lei
2018-10-12 9:02 ` John Garry
2018-10-12 13:30 ` Ming Lei
2018-10-12 10:47 ` John Garry
2018-10-16 4:28 ` Martin K. Petersen
2018-10-16 8:28 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011101534.GA31802@infradead.org \
--to=hch@infradead.org \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox