From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Christoph Hellwig <hch@lst.de>,
Matias Bjorling <matias.bjorling@wdc.com>
Subject: Re: [PATCH v3 09/11] block: Expose queue nr_zones in sysfs
Date: Fri, 12 Oct 2018 10:28:37 +0200 [thread overview]
Message-ID: <20181012082837.GC30248@lst.de> (raw)
In-Reply-To: <c13f3820-9a69-6a74-e967-b561d7778bcf@suse.de>
On Fri, Oct 12, 2018 at 09:41:28AM +0200, Hannes Reinecke wrote:
>> +{
>> + return 0;
>> +}
>> #endif /* CONFIG_BLK_DEV_ZONED */
>> static inline bool rq_is_sync(struct request *rq)
>>
> Actually, we should be checking whether we can't blank out this attribute
> via the is_visible mechanism; after all, not every block device is zoned,
> and those which are not have no need of the attribute...
The answer would be 0 in this case. I'm not sure blanking out is worth
it as it will create a lot more code for very little gain..
next prev parent reply other threads:[~2018-10-12 8:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 2:30 [PATCH v3 00/11] Zoned block device support improvements Damien Le Moal
2018-10-12 2:30 ` [PATCH v3 01/11] scsi: sd_zbc: Rearrange code Damien Le Moal
2018-10-12 7:29 ` Hannes Reinecke
2018-10-12 2:30 ` [PATCH v3 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time Damien Le Moal
2018-10-12 7:33 ` Hannes Reinecke
2018-10-12 7:48 ` Damien Le Moal
2018-10-12 10:28 ` Matias Bjorling
2018-10-12 2:30 ` [PATCH v3 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks Damien Le Moal
2018-10-12 7:35 ` Hannes Reinecke
2018-10-12 7:50 ` Damien Le Moal
2018-10-12 2:30 ` [PATCH v3 04/11] block: Introduce blkdev_nr_zones() helper Damien Le Moal
2018-10-12 7:36 ` Hannes Reinecke
2018-10-12 2:30 ` [PATCH v3 05/11] block: Limit allocation of zone descriptors for report zones Damien Le Moal
2018-10-12 7:36 ` Hannes Reinecke
2018-10-12 2:30 ` [PATCH v3 06/11] block: Introduce BLKGETZONESZ ioctl Damien Le Moal
2018-10-12 7:37 ` Hannes Reinecke
2018-10-12 8:23 ` Christoph Hellwig
2018-10-12 2:30 ` [PATCH v3 07/11] block: Introduce BLKGETNRZONES ioctl Damien Le Moal
2018-10-12 7:37 ` Hannes Reinecke
2018-10-12 8:23 ` Christoph Hellwig
2018-10-12 2:30 ` [PATCH v3 08/11] block: Improve zone reset execution Damien Le Moal
2018-10-12 7:39 ` Hannes Reinecke
2018-10-12 2:30 ` [PATCH v3 09/11] block: Expose queue nr_zones in sysfs Damien Le Moal
2018-10-12 7:41 ` Hannes Reinecke
2018-10-12 7:55 ` Damien Le Moal
2018-10-12 8:41 ` Hannes Reinecke
2018-10-12 8:28 ` Christoph Hellwig [this message]
2018-10-12 8:29 ` Christoph Hellwig
2018-10-12 2:30 ` [PATCH v3 10/11] block: add a report_zones method Damien Le Moal
2018-10-12 7:42 ` Hannes Reinecke
2018-10-12 2:30 ` [PATCH v3 11/11] block: Introduce blk_revalidate_disk_zones() Damien Le Moal
2018-10-12 7:44 ` Hannes Reinecke
2018-10-12 8:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012082837.GC30248@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matias.bjorling@wdc.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox