public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Evan Green <evgreen@chromium.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Douglas Anderson <dianders@chromium.org>,
	Evan Green <evgreen@chromium.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom
Date: Fri, 11 Jan 2019 15:31:59 -0800	[thread overview]
Message-ID: <20190111233159.218342-1-evgreen@chromium.org> (raw)

CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
this was the only possible PHY driver Qualcomm's UFS controller
would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
and phy-qcom-ufs is unused.

Remove the select, since for SDM845 it adds useless drivers to the
build.

Signed-off-by: Evan Green <evgreen@chromium.org>
---

 drivers/scsi/ufs/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index 2ddbb26d9c265..6db37cf306b05 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -99,7 +99,6 @@ config SCSI_UFS_DWC_TC_PLATFORM
 config SCSI_UFS_QCOM
 	tristate "QCOM specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && ARCH_QCOM
-	select PHY_QCOM_UFS
 	help
 	  This selects the QCOM specific additions to UFSHCD platform driver.
 	  UFS host on QCOM needs some vendor specific configuration before
-- 
2.18.1

             reply	other threads:[~2019-01-11 23:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 23:31 Evan Green [this message]
2019-01-12  3:37 ` [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom Martin K. Petersen
2019-01-14 17:07   ` Doug Anderson
2019-01-14 18:41     ` Evan Green
2019-01-14 19:11       ` Evan Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190111233159.218342-1-evgreen@chromium.org \
    --to=evgreen@chromium.org \
    --cc=dianders@chromium.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox