Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

Nathan Chancellor
2019-01-14T04:57:54Z

On Sun, Jan 13, 2019 at 08:54:35PM -0800, Bart Van Assche wrote:
> On 1/13/19 8:42 PM, Nathan Chancellor wrote:
> > @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg)
> > ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl));
> > if (IS_ERR(ioctl)) {
> > esas2r_log(ESAS2R_LOG_WARN,
> > - "ioctl_handler access_ok failed for cmd %d, "
> > + "ioctl_handler access_ok failed for cmd %u, "
> > "address %p", cmd,
> > arg);
> > return PTR_ERR(ioctl);
>
> If you have to repost this patch, please use that opportunity to join the
> above split strings. Additionally, since this patch touches much more SCSI

Sorry, I should have caught that. If I have to post again, I will fix
that.

> code than ATA code I think it should have been sent to Martin instead of to
> Jens. Anyway:
>

I had Jens, Martin, and James on the 'to' line, with all of the other
maintainers of the individual files on cc. If I should have done it
differently, please let me know.

> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>

Thank you, I will carry this forward if I need to.

Nathan