From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] scsi: ufs: Consider device limitations for dma_mask
Date: Mon, 14 Jan 2019 03:11:09 -0800 [thread overview]
Message-ID: <20190114111109.GA18673@infradead.org> (raw)
In-Reply-To: <20190111225402.6133-1-bjorn.andersson@linaro.org>
On Fri, Jan 11, 2019 at 02:54:02PM -0800, Bjorn Andersson wrote:
> */
> static int ufshcd_set_dma_mask(struct ufs_hba *hba)
> {
> - if (hba->capabilities & MASK_64_ADDRESSING_SUPPORT) {
> - if (!dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(64)))
> - return 0;
> - }
> - return dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(32));
> + u64 dma_mask = dma_get_mask(hba->dev);
> +
> + if (hba->capabilities & MASK_64_ADDRESSING_SUPPORT)
> + dma_mask &= DMA_BIT_MASK(64);
> + else
> + dma_mask &= DMA_BIT_MASK(32);
> +
> + return dma_set_mask_and_coherent(hba->dev, dma_mask);
NAK. ufshcd clearly is in charge of setting the dma mask, so reading
it back from someone else who might have set it is completely bogus.
You either need to introduce a quirk or a way to communicate the
different limit so that it can be set by the core.
next prev parent reply other threads:[~2019-01-14 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 22:54 [PATCH] scsi: ufs: Consider device limitations for dma_mask Bjorn Andersson
2019-01-11 23:33 ` Doug Anderson
2019-01-12 17:46 ` Bjorn Andersson
2019-01-14 11:11 ` Christoph Hellwig [this message]
2019-01-14 17:30 ` Bjorn Andersson
2019-01-14 17:36 ` Christoph Hellwig
2019-01-14 20:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114111109.GA18673@infradead.org \
--to=hch@infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox