From: Mark Brown <broonie@kernel.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: SCSI <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Evan Green <evgreen@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
Joao Pinto <jpinto@synopsys.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Bart Van Assche <bart.vanassche@wdc.com>,
Stanislav Nijnikov <stanislav.nijnikov@wdc.com>,
Alex Lemberg <alex.lemberg@wdc.com>,
Ohad Sharabi <ohad.sharabi@wdc.com>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
Subhash Jadavani <subhashj@codeaurora.org>,
Yaniv Gardi <ygardi@codeaurora.org>
Subject: Re: [PATCH v5 1/2] scsi: ufs: Do not disable vccq in UFSHC driver
Date: Mon, 11 Feb 2019 17:23:40 +0000 [thread overview]
Message-ID: <20190211172340.GG22391@sirena.org.uk> (raw)
In-Reply-To: <be3ef9bf-438b-4e8a-62c4-f75458e8ecc0@free.fr>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Mon, Feb 11, 2019 at 02:32:15PM +0100, Marc Gonzalez wrote:
> Unfortunately, this optimization breaks UFS on systems where vccq
> powers not only the Flash chip, but the host controller as well,
> such as APQ8098 MEDIABOX or MTP8998:
...
> In my opinion, the rationale for the original patch is questionable.
> If neither the UFSHC, nor the Flash chip, require any load from vccq,
> then that power rail should simply not be specified at all in the DT.
If the supply is physically connected it should be valid to represent
this in DT regardless of how or if the supply gets used at runtime.
However it does sound like this support needs to be better thought
through to make sure we have represented the supplies to the flash chip
and the controller separately - it seems like right now there's no
tracking of the supplies needed for the controller and the assumption is
that only the flash chip needs managing which is breaking things.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-11 17:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190211133457epcas3p2dc95fa2c93c3cf884a376f0282be8b8a@epcas3p2.samsung.com>
2019-02-11 13:31 ` [PATCH v5 0/2] Clean up UFSHC driver Marc Gonzalez
2019-02-11 13:32 ` [PATCH v5 1/2] scsi: ufs: Do not disable vccq in " Marc Gonzalez
2019-02-11 17:23 ` Mark Brown [this message]
2019-02-13 10:05 ` Marc Gonzalez
2019-02-26 9:05 ` Avri Altman
2019-02-26 14:44 ` Martin K. Petersen
2019-02-26 14:45 ` Marc Gonzalez
2019-02-26 14:52 ` Martin K. Petersen
2019-02-26 15:30 ` Marc Gonzalez
2019-02-26 16:26 ` Martin K. Petersen
2019-02-26 17:02 ` Marc Gonzalez
2019-02-26 20:00 ` Martin K. Petersen
2019-02-11 13:33 ` [PATCH v5 2/2] scsi: ufs: Remove unused device quirks Marc Gonzalez
2019-02-26 9:05 ` Avri Altman
2019-02-26 17:14 ` Evan Green
2019-02-13 10:25 ` [PATCH v5 0/2] Clean up UFSHC driver Alim Akhtar
2019-02-23 9:39 ` Marc Gonzalez
2019-02-26 8:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211172340.GG22391@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alex.lemberg@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bart.vanassche@wdc.com \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=jpinto@synopsys.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=ohad.sharabi@wdc.com \
--cc=pedrom.sousa@synopsys.com \
--cc=robh+dt@kernel.org \
--cc=stanislav.nijnikov@wdc.com \
--cc=subhashj@codeaurora.org \
--cc=venkatg@codeaurora.org \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox