From: Rajendra Nayak <rnayak@codeaurora.org>
To: vinholikatti@gmail.com, alim.akhtar@samsung.com,
pedrom.Sousa@synopsys.com
Cc: subhashj@codeaurora.org, asutoshd@codeaurora.org,
linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>
Subject: [PATCH 2/3] scsi: ufs: Add error checks for pm_runtime_get_sync()
Date: Fri, 8 Mar 2019 14:00:52 +0530 [thread overview]
Message-ID: <20190308083053.30631-3-rnayak@codeaurora.org> (raw)
In-Reply-To: <20190308083053.30631-1-rnayak@codeaurora.org>
Add an error check for pm_runtime_get_sync(), ignoring this can
hide issues with the runtime pm handling in the driver.
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 2ddf24466a62..060dc38cc582 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -8357,7 +8357,10 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
}
/* Hold auto suspend until async scan completes */
- pm_runtime_get_sync(dev);
+ err = pm_runtime_get_sync(dev);
+ if (err < 0)
+ goto out_remove_scsi_host;
+
atomic_set(&hba->scsi_block_reqs_cnt, 0);
/*
* We are assuming that device wasn't put in sleep/power-down
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-03-08 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 8:30 [PATCH 0/3] scsi: ufs: runtime pm fixes Rajendra Nayak
2019-03-08 8:30 ` [PATCH 1/3] scsi: ufs: Fix runtime pm handling in ufshcd-pltfrm Rajendra Nayak
2019-03-08 8:30 ` Rajendra Nayak [this message]
2019-03-12 14:06 ` [PATCH 2/3] scsi: ufs: Add error checks for pm_runtime_get_sync() Avri Altman
2019-03-08 8:30 ` [PATCH 3/3] scsi: ufs: qcom: Remove unnecessary runtime pm calls Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308083053.30631-3-rnayak@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pedrom.Sousa@synopsys.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox