Re: [PATCH] scsi: gdth: Only call dma_free_coherent when buf is not NULL in ioc_general

Martin K. Petersen
2019-03-26T02:23:16Z

Nathan,

> When building with -Wsometimes-uninitialized, Clang warns:
>
> drivers/scsi/gdth.c:3662:6: warning: variable 'paddr' is used
> uninitialized whenever 'if' condition is false
> [-Wsometimes-uninitialized]
>
> Don't attempt to call dma_free_coherent when buf is NULL (meaning that
> we never called dma_alloc_coherent and initialized paddr), which avoids
> this warning.

Applied to 5.2/scsi-queue, thanks.

--
Martin K. Petersen Oracle Linux Engineering