From: Al Viro <viro@zeniv.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Frank Haverkamp <haver@linux.ibm.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Felipe Balbi <balbi@kernel.org>,
Jerry Zhang <zhangjerry@google.com>,
Vincent Pelletier <plr.vincent@gmail.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
Shen Jing <jingx.shen@intel.com>,
linuxppc-dev@list
Subject: Re: [PATCH v3 10/26] compat_ioctl: use correct compat_ptr() translation in drivers
Date: Wed, 17 Apr 2019 22:21:11 +0100 [thread overview]
Message-ID: <20190417212111.GX2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190416202013.4034148-11-arnd@arndb.de>
On Tue, Apr 16, 2019 at 10:19:48PM +0200, Arnd Bergmann wrote:
> A handful of drivers all have a trivial wrapper around their ioctl
> handler, but don't call the compat_ptr() conversion function at the
> moment. In practice this does not matter, since none of them are used
> on the s390 architecture and for all other architectures, compat_ptr()
> does not do anything, but using the new compat_ptr_ioctl()
> helper makes it more correct in theory, and simplifies the code.
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/misc/cxl/flash.c | 8 +-------
> drivers/misc/genwqe/card_dev.c | 23 +----------------------
> drivers/scsi/megaraid/megaraid_mm.c | 28 +---------------------------
> drivers/usb/gadget/function/f_fs.c | 12 +-----------
ACK, provided that all their ioctls are taking pointers (which is
worth mentioning in commit message, assuming it's true)
next prev parent reply other threads:[~2019-04-17 21:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 20:19 [PATCH v3 00/26] compat_ioctl: cleanups Arnd Bergmann
2019-04-16 20:19 ` [PATCH v3 10/26] compat_ioctl: use correct compat_ptr() translation in drivers Arnd Bergmann
2019-04-17 21:21 ` Al Viro [this message]
[not found] ` <20190416202013.4034148-1-arnd-r2nGTMty4D4@public.gmane.org>
2019-04-16 20:25 ` [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl Arnd Bergmann
2019-04-16 20:25 ` [PATCH v3 13/26] compat_ioctl: move tape handling into drivers Arnd Bergmann
2019-04-25 15:21 ` [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl Mauro Carvalho Chehab
2019-04-25 15:32 ` Arnd Bergmann
2019-04-25 15:35 ` Al Viro
2019-04-25 15:53 ` Mauro Carvalho Chehab
[not found] ` <20190425153534.GS2217-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2019-04-25 15:55 ` Arnd Bergmann
2019-04-25 16:42 ` Al Viro
[not found] ` <CAK8P3a2HmiYQJ2FV2FgLiFsD8M9UKteC9Jetx7ja06PQVZWYfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-25 21:25 ` Johannes Berg
[not found] ` <5511420228cb38d08a67c0f6a614b7671d7d23d4.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2019-04-26 7:46 ` Arnd Bergmann
2019-04-16 22:33 ` [PATCH v3 00/26] compat_ioctl: cleanups Douglas Gilbert
2019-04-17 9:26 ` Arnd Bergmann
2019-05-06 9:03 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417212111.GX2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=andrew.donnellan@au1.ibm.com \
--cc=andrzej.p@collabora.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=fbarrat@linux.ibm.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=haver@linux.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=jingx.shen@intel.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@list \
--cc=martin.petersen@oracle.com \
--cc=plr.vincent@gmail.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=y2038@lists.linaro.org \
--cc=zhangjerry@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox