From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
devel@driverdev.osuosl.org, Hannes Reinecke <hare@suse.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Smart <james.smart@broadcom.com>,
"Ewan D . Milne" <emilne@redhat.com>, Jim Gill <jgill@vmware.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Brian King <brking@us.ibm.com>,
Finn Thain <fthain@telegraphics.com.au>,
"Juergen E . Fischer" <fischer@norbit.de>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl
Date: Thu, 13 Jun 2019 13:24:25 +0300 [thread overview]
Message-ID: <20190613102425.GB28859@kadam> (raw)
In-Reply-To: <20190613100410.GA10829@ming.t460p>
On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote:
> On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > > The current way isn't safe for chained sgl, so use sg helper to
> > > operate sgl.
> >
> > I can not make any sense out of this changelog.
> >
> > What "isn't safe"? What is a "sgl"?
>
> sgl is 'scatterlist' in kernel, and several linear sgl can be chained
> together, so accessing the sgl in linear way may see a chained sg, which
> is like a link pointer, then may cause trouble for driver.
>
So from a user perspective it results in an Oops? It would be really
cool if you had the copy of the Oops btw so people could grep the git
history for it.
(You need to resend with the improved commit message).
regards,
dan carpenter
prev parent reply other threads:[~2019-06-13 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190613071335.5679-1-ming.lei@redhat.com>
2019-06-13 7:13 ` [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl Ming Lei
2019-06-13 9:52 ` Greg Kroah-Hartman
2019-06-13 10:04 ` Ming Lei
2019-06-13 10:16 ` Greg Kroah-Hartman
2019-06-13 15:46 ` James Bottomley
2019-06-13 10:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613102425.GB28859@kadam \
--to=dan.carpenter@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=brking@us.ibm.com \
--cc=bvanassche@acm.org \
--cc=devel@driverdev.osuosl.org \
--cc=emilne@redhat.com \
--cc=fischer@norbit.de \
--cc=fthain@telegraphics.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jgill@vmware.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox