From: Minwoo Im <minwoo.im.dev@gmail.com>
To: "Matias Bjørling" <mb@lightnvm.io>
Cc: axboe@fb.com, hch@lst.de, damien.lemoal@wdc.com,
chaitanya.kulkarni@wdc.com, dmitry.fomichev@wdc.com,
ajay.joshi@wdc.com, aravind.ramesh@wdc.com,
martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com, agk@redhat.com,
snitzer@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
dm-devel@redhat.com, "Matias Bjørling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH 1/4] block: add zone open, close and finish support
Date: Sat, 22 Jun 2019 15:04:44 +0900 [thread overview]
Message-ID: <20190622060444.GA6975@minwooim-desktop> (raw)
In-Reply-To: <20190621130711.21986-2-mb@lightnvm.io>
On 19-06-21 15:07:08, Matias Bjørling wrote:
> @@ -226,6 +228,9 @@ int blkdev_reset_zones(struct block_device *bdev,
> if (!blk_queue_is_zoned(q))
> return -EOPNOTSUPP;
>
> + if (!op_is_zone_mgmt_op(op))
> + return -EOPNOTSUPP;
> +
nitpick: -EINVAL looks better to return as Damien pointed out.
Otherwise it looks good to me:
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
next prev parent reply other threads:[~2019-06-22 6:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 13:07 [PATCH 0/4] open, close, finish zone support Matias Bjørling
2019-06-21 13:07 ` [PATCH 1/4] block: add zone open, close and finish support Matias Bjørling
2019-06-22 0:51 ` Damien Le Moal
2019-06-24 10:36 ` Matias Bjørling
2019-06-22 6:04 ` Minwoo Im [this message]
2019-06-24 19:43 ` Bart Van Assche
2019-06-24 22:27 ` Chaitanya Kulkarni
2019-06-25 10:35 ` Matias Bjørling
2019-06-25 15:55 ` Bart Van Assche
2019-06-25 16:30 ` Javier González
2019-06-25 16:51 ` Chaitanya Kulkarni
2019-06-25 16:53 ` Matias Bjørling
2019-06-26 0:44 ` Damien Le Moal
2019-06-26 0:42 ` Damien Le Moal
2019-06-21 13:07 ` [PATCH 2/4] null_blk: add zone open, close, " Matias Bjørling
2019-06-22 1:02 ` Damien Le Moal
2019-06-25 11:06 ` Matias Bjørling
2019-06-25 12:36 ` Damien Le Moal
2019-06-25 13:03 ` Matias Bjørling
2019-06-21 13:07 ` [PATCH 3/4] scsi: sd_zbc: " Matias Bjørling
2019-06-22 1:12 ` Damien Le Moal
2019-06-24 19:46 ` Bart Van Assche
2019-06-25 10:32 ` Matias Bjørling
2019-06-21 13:07 ` [PATCH 4/4] dm: add zone open, close " Matias Bjørling
2019-06-22 1:15 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190622060444.GA6975@minwooim-desktop \
--to=minwoo.im.dev@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agk@redhat.com \
--cc=ajay.joshi@wdc.com \
--cc=aravind.ramesh@wdc.com \
--cc=axboe@fb.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=dmitry.fomichev@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matias.bjorling@wdc.com \
--cc=mb@lightnvm.io \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox