From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minwoo Im Subject: Re: [PATCH V2] mpt3sas: support target smid for [abort|query] task Date: Fri, 26 Jul 2019 01:53:27 +0900 Message-ID: <20190725165327.GA3081@minwoo-desktop> References: <20190714034415epcms2p25f9787cb71993a30f58524d2f355b543@epcms2p2> <860cc8cf-6419-c649-b2d9-19b82f6ebc99@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sreekanth Reddy Cc: Hannes Reinecke , minwoo.im@samsung.com, "sathya.prakash@broadcom.com" , "suganath-prabu.subramani@broadcom.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "MPT-FusionLinux.pdl@broadcom.com" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-block@vger.kernel.org" , Euihyeok Kwon , Sarah Cho , Sanggwan Lee , Gyeongmin Nam , Sungjun Park , Minwoo Im List-Id: linux-scsi@vger.kernel.org On 19-07-23 16:57:49, Sreekanth Reddy wrote: > On Mon, Jul 15, 2019 at 11:43 AM Hannes Reinecke wrote: > > I think this is fundamentally wrong. > > ABORT_TASK is used to abort a single task, which of course has to be > > known beforehand. If you don't know the task, what exactly do you hope > > to achieve here? Aborting random I/O? > > Or, even worse, aborting I/O the driver uses internally and corrupt the > > internal workflow of the driver? > > > > We should simply disallow any ABORT TASK from userspace if the TaskMID > > is zero. And I would even argue to disabllow ABORT TASK from userspace > > completely, as the smid is never relayed to userland, and as such the > > user cannot know which task should be aborted. > > Hannes, > > This interface was added long time back in mpt2sas driver and I don't > have exact reason of adding this interface at that time. > But I know that this interface is still used by BRCM test team & few > customers only for some functionality and regression testing. Sreekanth, and Hannes, Could you please give some review points on this? Thanks,