From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] scsi: ibmvfc: Mark expected switch fall-throughs
Date: Mon, 29 Jul 2019 09:38:42 -0700 [thread overview]
Message-ID: <201907290938.022D08EA@keescook> (raw)
In-Reply-To: <20190729002608.GA25263@embeddedor>
On Sun, Jul 28, 2019 at 07:26:08PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_npiv_login_done':
> drivers/scsi/ibmvscsi/ibmvfc.c:4022:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> ibmvfc_retry_host_init(vhost);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/ibmvscsi/ibmvfc.c:4023:2: note: here
> case IBMVFC_MAD_DRIVER_FAILED:
> ^~~~
> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_bsg_request':
> drivers/scsi/ibmvscsi/ibmvfc.c:1830:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
> port_id = (bsg_request->rqst_data.h_els.port_id[0] << 16) |
> ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> (bsg_request->rqst_data.h_els.port_id[1] << 8) |
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> bsg_request->rqst_data.h_els.port_id[2];
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/ibmvscsi/ibmvfc.c:1833:2: note: here
> case FC_BSG_RPT_ELS:
> ^~~~
> drivers/scsi/ibmvscsi/ibmvfc.c:1838:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
> port_id = (bsg_request->rqst_data.h_ct.port_id[0] << 16) |
> ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> (bsg_request->rqst_data.h_ct.port_id[1] << 8) |
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> bsg_request->rqst_data.h_ct.port_id[2];
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/ibmvscsi/ibmvfc.c:1841:2: note: here
> case FC_BSG_RPT_CT:
> ^~~~
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 8cdbac076a1b..df897df5cafe 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -1830,6 +1830,7 @@ static int ibmvfc_bsg_request(struct bsg_job *job)
> port_id = (bsg_request->rqst_data.h_els.port_id[0] << 16) |
> (bsg_request->rqst_data.h_els.port_id[1] << 8) |
> bsg_request->rqst_data.h_els.port_id[2];
> + /* fall through */
> case FC_BSG_RPT_ELS:
> fc_flags = IBMVFC_FC_ELS;
> break;
> @@ -1838,6 +1839,7 @@ static int ibmvfc_bsg_request(struct bsg_job *job)
> port_id = (bsg_request->rqst_data.h_ct.port_id[0] << 16) |
> (bsg_request->rqst_data.h_ct.port_id[1] << 8) |
> bsg_request->rqst_data.h_ct.port_id[2];
> + /* fall through */
> case FC_BSG_RPT_CT:
> fc_flags = IBMVFC_FC_CT_IU;
> break;
> @@ -4020,6 +4022,7 @@ static void ibmvfc_npiv_login_done(struct ibmvfc_event *evt)
> return;
> case IBMVFC_MAD_CRQ_ERROR:
> ibmvfc_retry_host_init(vhost);
> + /* fall through */
> case IBMVFC_MAD_DRIVER_FAILED:
> ibmvfc_free_event(evt);
> return;
> --
> 2.22.0
>
--
Kees Cook
next prev parent reply other threads:[~2019-07-29 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 0:26 [PATCH] scsi: ibmvfc: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-29 16:38 ` Kees Cook [this message]
2019-07-31 1:41 ` Tyrel Datwyler
2019-08-08 1:31 ` Martin K. Petersen
2019-08-08 1:31 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907290938.022D08EA@keescook \
--to=keescook@chromium.org \
--cc=benh@kernel.crashing.org \
--cc=gustavo@embeddedor.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox