From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 5/7] block: Delay default elevator initialization
Date: Tue, 3 Sep 2019 23:47:16 -0700 [thread overview]
Message-ID: <20190904064716.GA17496@infradead.org> (raw)
In-Reply-To: <BN8PR04MB581263CA0FBCED3394722EF9E7B80@BN8PR04MB5812.namprd04.prod.outlook.com>
On Wed, Sep 04, 2019 at 02:07:39AM +0000, Damien Le Moal wrote:
> OK. I will move the registration earlier in device_add_disk(), before the region
> registration.
>
> However, I would still like to keep the queue freeze to protect against buggy
> device drivers that call device_add_disk() with internal commands still going
> on. I do not think that there are any such driver, but just want to avoid
> problems. The queue freeze is also present for any user initiated elevator
> change, so in this respect, this is not any different and should not be a big
> problem. Thoughts ?
I don't really see the point, but there should be no harm it either
since a freeze of a non-busy queue should be fast.
next prev parent reply other threads:[~2019-09-04 6:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 2:29 [PATCH v2 0/7] Elevator cleanups and improvements Damien Le Moal
2019-08-28 2:29 ` [PATCH v2 1/7] block: Cleanup elevator_init_mq() use Damien Le Moal
2019-09-03 8:55 ` Christoph Hellwig
2019-08-28 2:29 ` [PATCH v2 2/7] block: Change elevator_init_mq() to always succeed Damien Le Moal
2019-09-03 8:55 ` Christoph Hellwig
2019-08-28 2:29 ` [PATCH v2 3/7] block: Introduce elevator features Damien Le Moal
2019-08-28 8:16 ` Johannes Thumshirn
2019-08-28 10:41 ` Damien Le Moal
2019-08-28 10:43 ` Johannes Thumshirn
2019-08-28 11:08 ` Damien Le Moal
2019-08-28 11:11 ` Johannes Thumshirn
2019-09-03 8:56 ` Christoph Hellwig
2019-08-28 2:29 ` [PATCH v2 4/7] block: Improve default elevator selection Damien Le Moal
2019-09-03 8:57 ` Christoph Hellwig
2019-09-04 8:42 ` Damien Le Moal
2019-08-28 2:29 ` [PATCH v2 5/7] block: Delay default elevator initialization Damien Le Moal
2019-09-03 9:02 ` Christoph Hellwig
2019-09-04 2:07 ` Damien Le Moal
2019-09-04 6:47 ` Christoph Hellwig [this message]
2019-08-28 2:29 ` [PATCH v2 6/7] block: Set ELEVATOR_F_ZBD_SEQ_WRITE for nullblk zoned disks Damien Le Moal
2019-09-03 9:03 ` Christoph Hellwig
2019-08-28 2:29 ` [PATCH v2 7/7] scsi: Set ELEVATOR_F_ZBD_SEQ_WRITE for ZBC disks Damien Le Moal
2019-09-03 9:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904064716.GA17496@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).