From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH tip/core/rcu 4/9] drivers/scsi: Replace rcu_swap_protected() with rcu_replace()
Date: Sat, 5 Oct 2019 09:06:53 -0700 [thread overview]
Message-ID: <20191005160653.GD2689@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <yq1zhihqn1g.fsf@oracle.com>
On Thu, Oct 03, 2019 at 10:09:31PM -0400, Martin K. Petersen wrote:
>
> Paul,
>
> No objections from me.
Thank you, Martin! I have applied your Acked-by, but please let me
know if that over-interprets your "No objections" above.
> > + vpd_pg80 = rcu_replace(sdev->vpd_pg80, vpd_pg80,
> > + lockdep_is_held(&sdev->inquiry_mutex));
> > + vpd_pg83 = rcu_replace(sdev->vpd_pg83, vpd_pg83,
> > + lockdep_is_held(&sdev->inquiry_mutex));
>
> Just a heads-up that we have added a couple of additional VPD pages so
> my 5.5 tree will need additional calls to be updated to rcu_replace().
I do not intend to actually remove rcu_swap_protected() until 5.6 for
exactly this sort of thing. My plan is to take another pass through
the tree after 5.5 comes out, and these will be caught at that time.
Does that work for you?
Thanx, Paul
next prev parent reply other threads:[~2019-10-05 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191003014153.GA13156@paulmck-ThinkPad-P72>
2019-10-03 1:43 ` [PATCH tip/core/rcu 4/9] drivers/scsi: Replace rcu_swap_protected() with rcu_replace() paulmck
2019-10-04 2:09 ` Martin K. Petersen
2019-10-05 16:06 ` Paul E. McKenney [this message]
2019-10-10 2:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005160653.GD2689@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox