Re: [PATCH 00/32] [NEW] efct: Broadcom (Emulex) FC Target driver

James Smart
2019-10-25T22:31:11Z

On 10/25/2019 8:56 AM, Daniel Wagner wrote:
> Hi James,
>
>> Review comments welcome!
>
> My compiler is complaining:
>
> home/wagi/work/linux/drivers/scsi/elx/efct/efct_driver.c: In function ‘efct_request_firmware_update’:
> /home/wagi/work/linux/drivers/scsi/elx/efct/efct_driver.c:350:3: warning: ‘fw_change_status’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 350 | switch (fw_change_status) {
> | ^~~~~~
> CC drivers/scsi/elx/libefc/efc_device.o
> CC drivers/scsi/elx/libefc/efc_lib.o
> CC drivers/scsi/elx/libefc/efc_sm.o
> CC drivers/scsi/elx/libefc_sli/sli4.o

Well, functionally it isn't an error as the way the code is written and
the writes occur, it will always have a valid value when there was no
call value. But, I can see how this is hard for the compiler to figure
out. We'll patch something to make the compiler happy.

> /home/wagi/work/linux/drivers/scsi/elx/libefc_sli/sli4.c: In function ‘sli_fc_rq_set_alloc’:
> /home/wagi/work/linux/drivers/scsi/elx/libefc_sli/sli4.c:818:12: warning: ‘offset’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 818 | u32 i, p, offset;
> | ^~~~~~

Yep - we will fix.

-- james