Re: [PATCH 31/32] elx: efct: Add Makefile and Kconfig for efct driver

Daniel Wagner
2019-10-25T15:55:31Z

Hi,

On Wed, Oct 23, 2019 at 02:55:56PM -0700, James Smart wrote:
> This patch completes the efct driver population.
>
> This patch adds driver definitions for:
> Adds the efct driver Kconfig and Makefiles
>
> Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
> drivers/scsi/elx/Kconfig | 8 ++++++++
> drivers/scsi/elx/Makefile | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 38 insertions(+)
> create mode 100644 drivers/scsi/elx/Kconfig
> create mode 100644 drivers/scsi/elx/Makefile
>
> diff --git a/drivers/scsi/elx/Kconfig b/drivers/scsi/elx/Kconfig
> new file mode 100644
> index 000000000000..3d25d8463c48
> --- /dev/null
> +++ b/drivers/scsi/elx/Kconfig
> @@ -0,0 +1,8 @@
> +config SCSI_EFCT
> + tristate "Emulex Fibre Channel Target"
> + depends on PCI && SCSI
> + depends on SCSI_FC_ATTRS

Is TARGET_ISCSI missing?

: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_npiv_drop_tpg':
efct_lio.c:(.text+0xa35): undefined reference to `core_tpg_deregister'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_drop_tpg':
efct_lio.c:(.text+0xa6e): undefined reference to `core_tpg_deregister'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_tmf_done':
efct_lio.c:(.text+0xceb): undefined reference to `transport_generic_free_cmd'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_async_worker':
efct_lio.c:(.text+0x1136): undefined reference to `target_submit_tmr'
ld: efct_lio.c:(.text+0x12b5): undefined reference to `target_setup_session'
ld: efct_lio.c:(.text+0x133c): undefined reference to `target_sess_cmd_list_set_waiting'
ld: efct_lio.c:(.text+0x1344): undefined reference to `target_wait_for_sess_cmds'
ld: efct_lio.c:(.text+0x134c): undefined reference to `target_remove_session'
ld: efct_lio.c:(.text+0x1464): undefined reference to `target_submit_cmd'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_status_done':
efct_lio.c:(.text+0x1579): undefined reference to `transport_generic_free_cmd'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_datamove_done':
efct_lio.c:(.text+0x1a01): undefined reference to `transport_generic_request_failure'
ld: efct_lio.c:(.text+0x1a6c): undefined reference to `transport_generic_free_cmd'
ld: efct_lio.c:(.text+0x1a87): undefined reference to `target_execute_cmd'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_make_tpg':
efct_lio.c:(.text+0x1ba4): undefined reference to `core_tpg_register'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_npiv_make_tpg':
efct_lio.c:(.text+0x2078): undefined reference to `core_tpg_register'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_scsi_tgt_driver_init':
efct_lio.c:(.text+0x2eba): undefined reference to `target_register_template'
ld: efct_lio.c:(.text+0x2ece): undefined reference to `target_register_template'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_scsi_tgt_driver_exit':
efct_lio.c:(.text+0x2ef8): undefined reference to `target_unregister_template'
ld: efct_lio.c:(.text+0x2f04): undefined reference to `target_unregister_template'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_lio_check_stop_free':
efct_lio.c:(.text+0xdf8): undefined reference to `target_put_sess_cmd'
ld: drivers/scsi/elx/efct/efct_lio.o: in function `efct_scsi_tgt_driver_init.cold':
efct_lio.c:(.text.unlikely+0x323): undefined reference to `target_unregister_template'
make[1]: *** [/home/wagi/work/linux/Makefile:1094: vmlinux] Error 1
make[1]: Leaving directory '/home/wagi/work/build/efct'

Thanks,
Daniel