From: kbuild test robot <lkp@intel.com>
To: James Smart <jsmart2021@gmail.com>
Cc: kbuild-all@lists.01.org, linux-scsi@vger.kernel.org,
James Smart <jsmart2021@gmail.com>,
Ram Vegesna <ram.vegesna@broadcom.com>
Subject: Re: [PATCH 32/32] elx: efct: Tie into kernel Kconfig and build process
Date: Sat, 26 Oct 2019 08:34:31 +0800 [thread overview]
Message-ID: <201910260807.ud4c6FJP%lkp@intel.com> (raw)
In-Reply-To: <20191023215557.12581-33-jsmart2021@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 7937 bytes --]
Hi James,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to v5.4-rc4 next-20191025]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/James-Smart/efct-Broadcom-Emulex-FC-Target-driver/20191026-050814
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/scsi/elx/libefc_sli/sli4.c: In function 'sli_fc_rq_set_alloc':
>> drivers/scsi/elx/libefc_sli/sli4.c:818:12: warning: 'offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
u32 i, p, offset;
^~~~~~
vim +/offset +818 drivers/scsi/elx/libefc_sli/sli4.c
8994bfd36daa33 James Smart 2019-10-23 795
8994bfd36daa33 James Smart 2019-10-23 796 /**
8994bfd36daa33 James Smart 2019-10-23 797 * @ingroup sli_fc
8994bfd36daa33 James Smart 2019-10-23 798 * @brief Write an RQ_CREATE_V2 command.
8994bfd36daa33 James Smart 2019-10-23 799 *
8994bfd36daa33 James Smart 2019-10-23 800 * @param sli4 SLI context.
8994bfd36daa33 James Smart 2019-10-23 801 * @param buf Destination buffer for the command.
8994bfd36daa33 James Smart 2019-10-23 802 * @param size Buffer size, in bytes.
8994bfd36daa33 James Smart 2019-10-23 803 * @param qmem DMA memory for the queue.
8994bfd36daa33 James Smart 2019-10-23 804 * @param cq_id Associated CQ_ID.
8994bfd36daa33 James Smart 2019-10-23 805 * @param buffer_size Buffer size pointed to by each RQE.
8994bfd36daa33 James Smart 2019-10-23 806 *
8994bfd36daa33 James Smart 2019-10-23 807 * @note This creates a Version 0 message
8994bfd36daa33 James Smart 2019-10-23 808 *
8994bfd36daa33 James Smart 2019-10-23 809 * @return Returns zero for success and non-zero for failure.
8994bfd36daa33 James Smart 2019-10-23 810 */
8994bfd36daa33 James Smart 2019-10-23 811 static int
8994bfd36daa33 James Smart 2019-10-23 812 sli_cmd_rq_create_v2(struct sli4_s *sli4, u32 num_rqs,
8994bfd36daa33 James Smart 2019-10-23 813 struct sli4_queue_s *qs[], u32 base_cq_id,
8994bfd36daa33 James Smart 2019-10-23 814 u32 header_buffer_size,
8994bfd36daa33 James Smart 2019-10-23 815 u32 payload_buffer_size, struct efc_dma_s *dma)
8994bfd36daa33 James Smart 2019-10-23 816 {
8994bfd36daa33 James Smart 2019-10-23 817 struct sli4_rqst_rq_create_v2_s *req = NULL;
8994bfd36daa33 James Smart 2019-10-23 @818 u32 i, p, offset;
8994bfd36daa33 James Smart 2019-10-23 819 u32 payload_size, page_count;
8994bfd36daa33 James Smart 2019-10-23 820 uintptr_t addr;
8994bfd36daa33 James Smart 2019-10-23 821 u32 num_pages;
8994bfd36daa33 James Smart 2019-10-23 822
8994bfd36daa33 James Smart 2019-10-23 823 page_count = sli_page_count(qs[0]->dma.size, SLI_PAGE_SIZE) * num_rqs;
8994bfd36daa33 James Smart 2019-10-23 824
8994bfd36daa33 James Smart 2019-10-23 825 /* Payload length must accommodate both request and response */
8994bfd36daa33 James Smart 2019-10-23 826 payload_size = max(CFG_RQST_CMDSZ(rq_create_v2) +
8994bfd36daa33 James Smart 2019-10-23 827 SZ_DMAADDR * page_count,
8994bfd36daa33 James Smart 2019-10-23 828 sizeof(struct sli4_rsp_cmn_create_queue_set_s));
8994bfd36daa33 James Smart 2019-10-23 829
8994bfd36daa33 James Smart 2019-10-23 830 dma->size = payload_size;
8994bfd36daa33 James Smart 2019-10-23 831 dma->virt = dma_alloc_coherent(&sli4->pcidev->dev, dma->size,
8994bfd36daa33 James Smart 2019-10-23 832 &dma->phys, GFP_DMA);
8994bfd36daa33 James Smart 2019-10-23 833 if (!dma->virt)
8994bfd36daa33 James Smart 2019-10-23 834 return EFC_FAIL;
8994bfd36daa33 James Smart 2019-10-23 835
8994bfd36daa33 James Smart 2019-10-23 836 memset(dma->virt, 0, payload_size);
8994bfd36daa33 James Smart 2019-10-23 837
8994bfd36daa33 James Smart 2019-10-23 838 req = sli_config_cmd_init(sli4, sli4->bmbx.virt, SLI4_BMBX_SIZE,
8994bfd36daa33 James Smart 2019-10-23 839 payload_size, dma);
8994bfd36daa33 James Smart 2019-10-23 840 if (!req)
8994bfd36daa33 James Smart 2019-10-23 841 return EFC_FAIL;
8994bfd36daa33 James Smart 2019-10-23 842
8994bfd36daa33 James Smart 2019-10-23 843 /* Fill Header fields */
8994bfd36daa33 James Smart 2019-10-23 844 req->hdr.opcode = SLI4_OPC_RQ_CREATE;
8994bfd36daa33 James Smart 2019-10-23 845 req->hdr.subsystem = SLI4_SUBSYSTEM_FC;
8994bfd36daa33 James Smart 2019-10-23 846 req->hdr.dw3_version = cpu_to_le32(CMD_V2);
8994bfd36daa33 James Smart 2019-10-23 847 req->hdr.request_length = CFG_RQST_PYLD_LEN_VAR(rq_create_v2,
8994bfd36daa33 James Smart 2019-10-23 848 SZ_DMAADDR * page_count);
8994bfd36daa33 James Smart 2019-10-23 849
8994bfd36daa33 James Smart 2019-10-23 850 /* Fill Payload fields */
8994bfd36daa33 James Smart 2019-10-23 851 req->dim_dfd_dnb |= SLI4_RQCREATEV2_DNB;
8994bfd36daa33 James Smart 2019-10-23 852 num_pages = sli_page_count(qs[0]->dma.size, SLI_PAGE_SIZE);
8994bfd36daa33 James Smart 2019-10-23 853 req->num_pages = cpu_to_le16(num_pages);
8994bfd36daa33 James Smart 2019-10-23 854 req->rqe_count = cpu_to_le16(qs[0]->dma.size / SLI4_RQE_SIZE);
8994bfd36daa33 James Smart 2019-10-23 855 req->rqe_size_byte |= SLI4_RQE_SIZE_8;
8994bfd36daa33 James Smart 2019-10-23 856 req->page_size = SLI4_RQ_PAGE_SIZE_4096;
8994bfd36daa33 James Smart 2019-10-23 857 req->rq_count = num_rqs;
8994bfd36daa33 James Smart 2019-10-23 858 req->base_cq_id = cpu_to_le16(base_cq_id);
8994bfd36daa33 James Smart 2019-10-23 859 req->hdr_buffer_size = cpu_to_le16(header_buffer_size);
8994bfd36daa33 James Smart 2019-10-23 860 req->payload_buffer_size = cpu_to_le16(payload_buffer_size);
8994bfd36daa33 James Smart 2019-10-23 861
8994bfd36daa33 James Smart 2019-10-23 862 for (i = 0; i < num_rqs; i++) {
8994bfd36daa33 James Smart 2019-10-23 863 for (p = 0, addr = qs[i]->dma.phys; p < num_pages;
8994bfd36daa33 James Smart 2019-10-23 864 p++, addr += SLI_PAGE_SIZE) {
8994bfd36daa33 James Smart 2019-10-23 865 req->page_phys_addr[offset].low =
8994bfd36daa33 James Smart 2019-10-23 866 cpu_to_le32(lower_32_bits(addr));
8994bfd36daa33 James Smart 2019-10-23 867 req->page_phys_addr[offset].high =
8994bfd36daa33 James Smart 2019-10-23 868 cpu_to_le32(upper_32_bits(addr));
8994bfd36daa33 James Smart 2019-10-23 869 offset++;
8994bfd36daa33 James Smart 2019-10-23 870 }
8994bfd36daa33 James Smart 2019-10-23 871 }
8994bfd36daa33 James Smart 2019-10-23 872
8994bfd36daa33 James Smart 2019-10-23 873 return EFC_SUCCESS;
8994bfd36daa33 James Smart 2019-10-23 874 }
8994bfd36daa33 James Smart 2019-10-23 875
:::::: The code at line 818 was first introduced by commit
:::::: 8994bfd36daa331dd81afd4af5a1d567fb75b6ac elx: libefc_sli: queue create/destroy/parse routines
:::::: TO: James Smart <jsmart2021@gmail.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54944 bytes --]
next prev parent reply other threads:[~2019-10-26 0:35 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 21:55 [PATCH 00/32] [NEW] efct: Broadcom (Emulex) FC Target driver James Smart
2019-10-23 21:55 ` [PATCH 01/32] elx: libefc_sli: SLI-4 register offsets and field definitions James Smart
2019-10-24 16:22 ` Daniel Wagner
2019-10-25 23:04 ` James Smart
2019-10-23 21:55 ` [PATCH 02/32] elx: libefc_sli: SLI Descriptors and Queue entries James Smart
2019-10-25 9:59 ` Daniel Wagner
2019-10-25 23:00 ` James Smart
2019-10-23 21:55 ` [PATCH 03/32] elx: libefc_sli: Data structures and defines for mbox commands James Smart
2019-10-25 11:19 ` Daniel Wagner
2019-10-25 12:20 ` Steffen Maier
2019-10-25 22:10 ` James Smart
2019-10-25 22:42 ` James Smart
2019-10-23 21:55 ` [PATCH 04/32] elx: libefc_sli: queue create/destroy/parse routines James Smart
2019-10-25 15:35 ` Daniel Wagner
2019-10-25 22:24 ` James Smart
2019-10-23 21:55 ` [PATCH 05/32] elx: libefc_sli: Populate and post different WQEs James Smart
2019-10-23 21:55 ` [PATCH 06/32] elx: libefc_sli: bmbx routines and SLI config commands James Smart
2019-10-23 21:55 ` [PATCH 07/32] elx: libefc_sli: APIs to setup SLI library James Smart
2019-10-23 21:55 ` [PATCH 08/32] elx: libefc: Generic state machine framework James Smart
2019-10-23 21:55 ` [PATCH 09/32] elx: libefc: Emulex FC discovery library APIs and definitions James Smart
2019-10-23 21:55 ` [PATCH 10/32] elx: libefc: FC Domain state machine interfaces James Smart
2019-10-23 21:55 ` [PATCH 11/32] elx: libefc: SLI and FC PORT " James Smart
2019-10-23 21:55 ` [PATCH 12/32] elx: libefc: Remote node " James Smart
2019-10-23 21:55 ` [PATCH 13/32] elx: libefc: Fabric " James Smart
2019-10-23 21:55 ` [PATCH 14/32] elx: libefc: FC node ELS and state handling James Smart
2019-10-23 21:55 ` [PATCH 15/32] elx: efct: Data structures and defines for hw operations James Smart
2019-10-23 21:55 ` [PATCH 16/32] elx: efct: Driver initialization routines James Smart
2019-10-23 21:55 ` [PATCH 17/32] elx: efct: Hardware queues creation and deletion James Smart
2019-10-23 21:55 ` [PATCH 18/32] elx: efct: RQ buffer, memory pool allocation and deallocation APIs James Smart
2019-10-23 21:55 ` [PATCH 19/32] elx: efct: Hardware IO and SGL initialization James Smart
2019-10-23 21:55 ` [PATCH 20/32] elx: efct: Hardware queues processing James Smart
2019-10-23 21:55 ` [PATCH 21/32] elx: efct: Unsolicited FC frame processing routines James Smart
2019-10-23 21:55 ` [PATCH 22/32] elx: efct: Extended link Service IO handling James Smart
2019-10-23 21:55 ` [PATCH 23/32] elx: efct: SCSI IO handling routines James Smart
2019-10-23 21:55 ` [PATCH 24/32] elx: efct: LIO backend interface routines James Smart
2019-10-24 22:27 ` Bart Van Assche
2019-10-28 17:49 ` James Smart
2019-10-28 18:31 ` Bart Van Assche
2019-10-23 21:55 ` [PATCH 25/32] elx: efct: Hardware IO submission routines James Smart
2019-10-23 21:55 ` [PATCH 26/32] elx: efct: link statistics and SFP data James Smart
2019-10-23 21:55 ` [PATCH 27/32] elx: efct: xport and hardware teardown routines James Smart
2019-10-23 21:55 ` [PATCH 28/32] elx: efct: IO timeout handling routines James Smart
2019-10-23 21:55 ` [PATCH 29/32] elx: efct: Firmware update, async link processing James Smart
2019-10-23 21:55 ` [PATCH 30/32] elx: efct: scsi_transport_fc host interface support James Smart
2019-10-23 21:55 ` [PATCH 31/32] elx: efct: Add Makefile and Kconfig for efct driver James Smart
2019-10-25 15:55 ` Daniel Wagner
2019-10-25 22:47 ` James Smart
2019-10-23 21:55 ` [PATCH 32/32] elx: efct: Tie into kernel Kconfig and build process James Smart
2019-10-26 0:34 ` kbuild test robot [this message]
2019-10-26 0:39 ` Randy Dunlap
2019-10-26 14:13 ` kbuild test robot
2019-10-26 14:13 ` [RFC PATCH] elx: efct: efct_libefc_templ can be static kbuild test robot
2019-10-25 15:56 ` [PATCH 00/32] [NEW] efct: Broadcom (Emulex) FC Target driver Daniel Wagner
2019-10-25 22:31 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910260807.ud4c6FJP%lkp@intel.com \
--to=lkp@intel.com \
--cc=jsmart2021@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ram.vegesna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox