From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bart van Assche <bvanassche@acm.org>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 51/52] scsi: Kill DRIVER_MEDIA, DRIVER_SOFT, and DRIVER_BUSY
Date: Mon, 4 Nov 2019 10:01:50 +0100 [thread overview]
Message-ID: <20191104090151.129140-52-hare@suse.de> (raw)
In-Reply-To: <20191104090151.129140-1-hare@suse.de>
Unused.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/message/fusion/mptscsih.c | 2 +-
drivers/scsi/constants.c | 2 +-
include/scsi/scsi.h | 8 --------
include/trace/events/scsi.h | 5 +----
4 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
index f0737c57ed5f..0064547cef1a 100644
--- a/drivers/message/fusion/mptscsih.c
+++ b/drivers/message/fusion/mptscsih.c
@@ -703,7 +703,7 @@ mptscsih_io_done(MPT_ADAPTER *ioc, MPT_FRAME_HDR *mf, MPT_FRAME_HDR *mr)
case MPI_IOCSTATUS_BUSY: /* 0x0002 */
case MPI_IOCSTATUS_INSUFFICIENT_RESOURCES: /* 0x0006 */
/* CHECKME!
- * Maybe: DRIVER_BUSY | SUGGEST_RETRY | DID_SOFT_ERROR (retry)
+ * Maybe: SUGGEST_RETRY | DID_SOFT_ERROR (retry)
* But not: DID_BUS_BUSY lest one risk
* killing interrupt handler:-(
*/
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index 57c544fd8c6b..be7eacb67841 100644
--- a/drivers/scsi/constants.c
+++ b/drivers/scsi/constants.c
@@ -407,7 +407,7 @@ static const char * const hostbyte_table[]={
"DID_NEXUS_FAILURE" };
static const char * const driverbyte_table[]={
-"DRIVER_OK", "DRIVER_BUSY", "DRIVER_SOFT", "DRIVER_MEDIA"};
+"DRIVER_OK"};
const char *scsi_hostbyte_string(int result)
{
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index af9f9ed5321e..acd0b2182db1 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -161,14 +161,6 @@ static inline int scsi_is_wlun(u64 lun)
#define DID_MEDIUM_ERROR 0x13 /* Medium error */
#define DRIVER_OK 0x00 /* Driver status */
-/*
- * These indicate the error that occurred, and what is available.
- */
-
-#define DRIVER_BUSY 0x01
-#define DRIVER_SOFT 0x02
-#define DRIVER_MEDIA 0x03
-
/*
* Internal return values.
*/
diff --git a/include/trace/events/scsi.h b/include/trace/events/scsi.h
index b2d3ce9e3990..5984db6996bb 100644
--- a/include/trace/events/scsi.h
+++ b/include/trace/events/scsi.h
@@ -127,10 +127,7 @@
#define scsi_driverbyte_name(result) { result, #result }
#define show_driverbyte_name(val) \
__print_symbolic(val, \
- scsi_driverbyte_name(DRIVER_OK), \
- scsi_driverbyte_name(DRIVER_BUSY), \
- scsi_driverbyte_name(DRIVER_SOFT), \
- scsi_driverbyte_name(DRIVER_MEDIA))
+ scsi_driverbyte_name(DRIVER_OK))
#define scsi_msgbyte_name(result) { result, #result }
#define show_msgbyte_name(val) \
--
2.16.4
next prev parent reply other threads:[~2019-11-04 9:02 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 9:00 [PATCHv3 00/52] Revamp SCSI result values Hannes Reinecke
2019-11-04 9:01 ` [PATCH 01/52] aic7xxx,aic79xxx: remove driver-defined SAM status definitions Hannes Reinecke
2019-11-04 9:01 ` [PATCH 02/52] bfa: drop driver-defined SCSI status codes Hannes Reinecke
2019-11-04 9:01 ` [PATCH 03/52] wd33c93: use SCSI status Hannes Reinecke
2019-11-04 9:01 ` [PATCH 04/52] acornscsi: use standard defines Hannes Reinecke
2019-11-04 9:01 ` [PATCH 05/52] libata-scsi: use standard SAM status codes Hannes Reinecke
2019-11-04 17:36 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 06/52] ib_srp: " Hannes Reinecke
2019-11-04 17:36 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 07/52] 3w-xxxx: " Hannes Reinecke
2019-11-04 17:37 ` Bart Van Assche
2019-11-05 2:06 ` adam radford
2019-11-04 9:01 ` [PATCH 08/52] arcmsr: " Hannes Reinecke
2019-11-04 17:37 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 09/52] dc395x: " Hannes Reinecke
2019-11-04 17:38 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 10/52] megaraid: " Hannes Reinecke
2019-11-04 17:39 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 11/52] megaraid_mboxi: " Hannes Reinecke
2019-11-04 17:39 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 12/52] gdth: " Hannes Reinecke
2019-11-04 17:40 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 13/52] dpt_i2o: " Hannes Reinecke
2019-11-04 17:40 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 14/52] nsp_cs: " Hannes Reinecke
2019-11-04 17:42 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 15/52] nsp32: fixup status handling Hannes Reinecke
2019-11-04 9:01 ` [PATCH 16/52] dc395: drop private SAM status code definitions Hannes Reinecke
2019-11-04 17:42 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 17/52] qla4xxx: use standard SAM status definitions Hannes Reinecke
2019-11-04 17:43 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 18/52] scsi: change status_byte() to return the standard SCSI status Hannes Reinecke
2019-11-04 17:45 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 19/52] target_core: Fixup target_complete_cmd() usage Hannes Reinecke
2019-11-04 9:01 ` [PATCH 20/52] sg: use SAM status definitions and avoid using masked_status Hannes Reinecke
2019-11-05 6:03 ` Douglas Gilbert
2019-11-04 9:01 ` [PATCH 21/52] initio: use standard SAM status definitions Hannes Reinecke
2019-11-04 17:46 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 22/52] scsi: Kill obsolete linux-specific status codes Hannes Reinecke
2019-11-04 17:46 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 23/52] scsi: introduce set_status_byte() Hannes Reinecke
2019-11-04 9:01 ` [PATCH 24/52] advansys: kill driver_defined status byte accessors Hannes Reinecke
2019-11-04 9:01 ` [PATCH 25/52] scsi: introduce scsi_build_sense() Hannes Reinecke
2019-11-04 17:47 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 26/52] libata-scsi: use scsi_build_sense() Hannes Reinecke
2019-11-04 9:01 ` [PATCH 27/52] zfcp: " Hannes Reinecke
2019-11-04 17:49 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 28/52] 3w-xxxx: " Hannes Reinecke
2019-11-04 17:49 ` Bart Van Assche
2019-11-05 2:13 ` adam radford
2019-11-04 9:01 ` [PATCH 29/52] libiscsi: " Hannes Reinecke
2019-11-04 17:49 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 30/52] lpfc: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 31/52] mpt3sas: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 32/52] mvumi: " Hannes Reinecke
2019-11-04 17:50 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 33/52] myrb: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 34/52] myrs: " Hannes Reinecke
2019-11-04 17:50 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 35/52] ps3rom: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 36/52] qla2xxx: " Hannes Reinecke
2019-11-04 17:51 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 37/52] scsi_debug: " Hannes Reinecke
2019-11-05 6:03 ` Douglas Gilbert
2019-11-04 9:01 ` [PATCH 38/52] smartpqi: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 39/52] stex: " Hannes Reinecke
2019-11-04 17:52 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 40/52] scsi: Kill DRIVER_SENSE Hannes Reinecke
2019-11-19 8:32 ` Martin Wilck
2019-11-04 9:01 ` [PATCH 41/52] scsi: Kill DRIVER_HARD Hannes Reinecke
2019-11-04 9:01 ` [PATCH 42/52] scsi_error: use DID_TIME_OUT instead of DRIVER_TIMEOUT Hannes Reinecke
2019-11-04 9:01 ` [PATCH 43/52] scsi: Kill DRIVER_TIMEOUT Hannes Reinecke
2019-11-04 9:01 ` [PATCH 44/52] scsi: do not use DRIVER_INVALID Hannes Reinecke
2019-11-04 9:01 ` [PATCH 45/52] st: return error code in st_scsi_execute() Hannes Reinecke
2019-11-04 9:01 ` [PATCH 46/52] scsi_ioctl: return error code when blk_rq_map_kern() fails Hannes Reinecke
2019-11-04 9:01 ` [PATCH 47/52] scsi_dh_alua: do not interpret DRIVER_ERROR Hannes Reinecke
2019-11-04 9:01 ` [PATCH 48/52] 3w-9xxx: Kill unreachable code in twa_interrupt() Hannes Reinecke
2019-11-05 2:04 ` adam radford
2019-11-04 9:01 ` [PATCH 49/52] xen-scsiback: stop using DRIVER_ERROR Hannes Reinecke
2019-11-04 9:01 ` [PATCH 50/52] scsi: " Hannes Reinecke
2019-11-04 9:01 ` Hannes Reinecke [this message]
2019-11-04 9:01 ` [PATCH 52/52] scsi: Drop the now obsolete driver_byte definitions Hannes Reinecke
2019-11-19 9:02 ` Martin Wilck
2019-11-19 9:31 ` Hannes Reinecke
2019-11-19 11:03 ` Martin Wilck
2019-11-19 11:56 ` Hannes Reinecke
2019-11-15 7:42 ` [PATCHv3 00/52] Revamp SCSI result values Hannes Reinecke
2019-11-19 3:35 ` Martin K. Petersen
2019-11-19 7:10 ` Hannes Reinecke
2019-11-20 3:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104090151.129140-52-hare@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).