From: Christoph Hellwig <hch@infradead.org>
To: Kars de Jong <jongk@linux-m68k.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>,
linux-scsi@vger.kernel.org, linux-m68k@vger.kernel.org,
schmitzmic@gmail.com, fthain@telegraphics.com.au
Subject: Re: [PATCH 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum
Date: Wed, 13 Nov 2019 06:22:08 -0800 [thread overview]
Message-ID: <20191113142208.GA8269@infradead.org> (raw)
In-Reply-To: <20191112185710.23988-2-jongk@linux-m68k.org>
On Tue, Nov 12, 2019 at 07:57:09PM +0100, Kars de Jong wrote:
> The order of the definitions in the esp_rev enum is important. The values
> are used in comparisons for chip features.
Yikes. Wouldn't it make much more sense to have a feature bitmap?
next prev parent reply other threads:[~2019-11-13 14:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191029220503.7553-1-jongk@linux-m68k.org>
2019-11-12 18:57 ` [PATCH 0/2] Some esp_scsi updates Kars de Jong
2019-11-12 18:57 ` [PATCH 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum Kars de Jong
2019-11-12 23:07 ` Finn Thain
2019-11-13 8:00 ` Kars de Jong
2019-11-13 22:25 ` Finn Thain
2019-11-13 14:22 ` Christoph Hellwig [this message]
2019-11-13 15:03 ` Kars de Jong
2019-11-12 18:57 ` [PATCH 2/2] esp_scsi: Add support for FSC chip Kars de Jong
2019-11-12 23:18 ` Finn Thain
2019-11-12 23:57 ` Finn Thain
2019-11-13 9:30 ` Kars de Jong
2019-11-13 22:24 ` Finn Thain
2019-11-14 21:59 ` [PATCH v2 0/2] Some esp_scsi updates Kars de Jong
2019-11-14 21:59 ` [PATCH 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum Kars de Jong
2019-11-14 22:06 ` Kars de Jong
2019-11-14 21:59 ` [PATCH 2/2] esp_scsi: Add support for FSC chip Kars de Jong
2019-11-14 22:07 ` Kars de Jong
2019-11-14 22:25 ` [PATCH v3 0/2] Some esp_scsi updates Kars de Jong
2019-11-14 22:25 ` [PATCH v2 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum Kars de Jong
2019-11-15 2:13 ` Finn Thain
2019-11-15 7:04 ` Kars de Jong
2019-11-14 22:25 ` [PATCH v3 2/2] esp_scsi: Add support for FSC chip Kars de Jong
2019-11-15 2:09 ` Finn Thain
2019-11-18 13:27 ` Kars de Jong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113142208.GA8269@infradead.org \
--to=hch@infradead.org \
--cc=fthain@telegraphics.com.au \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=jongk@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox