From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/5] aacraid: use scsi_host_busy_iter() for traversing outstanding commands
Date: Sat, 16 Nov 2019 17:33:57 +0100 [thread overview]
Message-ID: <20191116163357.GD23951@lst.de> (raw)
In-Reply-To: <20191115122757.132006-5-hare@suse.de>
On Fri, Nov 15, 2019 at 01:27:56PM +0100, Hannes Reinecke wrote:
> Use scsi_host_busy_iter() for traversing outstanding commands and
> drop the cmd_list usage.
This is missing all the feedback from last time, no maintainers are
Cced, it is not split up and properly documented, etc. It is still
reverse engineering the scsi commands instead of looking at the
block request.
And while looking at this again, I think the iteration in
aac_synchronize should simply be removed without a replacement. Cache
flushes in the Linux block layer and in SCSI have always only been
for complete commands, not for in-flight commands. So unless the
hardware has a weird quirk this code should just go away. Which is
another reason to add the maintainers at the hardware vendor, as they
can help with insights.
next prev parent reply other threads:[~2019-11-16 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 12:27 [PATCHv3 0/5] scsi: remove legacy cmd_list implementation Hannes Reinecke
2019-11-15 12:27 ` [PATCH 1/5] scsi: add scsi_host_busy_iter() Hannes Reinecke
2019-11-15 12:27 ` [PATCH 2/5] dpt_i2o: use midlayer tcq implementation Hannes Reinecke
2019-11-16 16:31 ` Christoph Hellwig
2019-11-17 15:01 ` Hannes Reinecke
2019-11-15 12:27 ` [PATCH 3/5] dpt_i2o: rename adpt_i2o_to_scsi() to adpt_i2o_scsi_complete() Hannes Reinecke
2019-11-15 12:27 ` [PATCH 4/5] aacraid: use scsi_host_busy_iter() for traversing outstanding commands Hannes Reinecke
2019-11-16 16:33 ` Christoph Hellwig [this message]
2019-11-15 12:27 ` [PATCH 5/5] scsi: Remove cmd_list functionality Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116163357.GD23951@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox