From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050CBC43603 for ; Tue, 17 Dec 2019 04:13:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFBF921835 for ; Tue, 17 Dec 2019 04:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576556032; bh=TQMMeBBZrVKYEy0YvA+gnlD3IzbyNHER3EDmj07O190=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=B/B+qZXIGZHp96Qp4SLWNGAN49OnIBgpNL4raU7I6lu54+QGeQAfuTrMHMrdyLjvL h3MKEQCO0EZuz4dFwJXkno9eK2X7kKiIoGxGXnBox/BEoMhQQGDy1A6L3J3hfIVruB 5JvIlFaUuQHRd4MUvw0c73EVTUA6q7BkW1hQtFZU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbfLQENt (ORCPT ); Mon, 16 Dec 2019 23:13:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:35914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbfLQENt (ORCPT ); Mon, 16 Dec 2019 23:13:49 -0500 Received: from localhost (unknown [171.61.91.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95A23206E6; Tue, 17 Dec 2019 04:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576556028; bh=TQMMeBBZrVKYEy0YvA+gnlD3IzbyNHER3EDmj07O190=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xJmHkIQcN4IiGutvhNuTe5LhQqWgs03XXk8b1vSQECWNfA31QEDiw7XQ2/6Omsx+L N3Ne/OmncLMpEHBBhuRJ82BZkKTT5/xa3O8cO6H5Fl9aYEjvFfC4ZmAy6ZhgmY/V+A Uurc8yJvr+4ET0UVLz/jET1qyN23Kv7XeGPf4dz0= Date: Tue, 17 Dec 2019 09:43:42 +0530 From: Vinod Koul To: cang@codeaurora.org Cc: Jeffrey Hugo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, Rajendra Nayak , linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Andy Gross , Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:ARM/QUALCOMM SUPPORT" , open list Subject: Re: [PATCH v5 2/7] scsi: ufs-qcom: Add reset control support for host controller Message-ID: <20191217041342.GM2536@vkoul-mobl> References: <1573798172-20534-1-git-send-email-cang@codeaurora.org> <1573798172-20534-3-git-send-email-cang@codeaurora.org> <20191216190415.GL2536@vkoul-mobl> <091562cbe7d88ca1c30638bc10197074@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <091562cbe7d88ca1c30638bc10197074@codeaurora.org> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Can, On 17-12-19, 08:37, cang@codeaurora.org wrote: > On 2019-12-17 03:12, Jeffrey Hugo wrote: > > On Mon, Dec 16, 2019 at 12:05 PM Vinod Koul wrote: > > > > > > Hi Can, > > > > > > On 14-11-19, 22:09, Can Guo wrote: > > > > Add reset control for host controller so that host controller can be reset > > > > as required in its power up sequence. > > > > > > I am seeing a regression on UFS on SM8150-mtp with this patch. I think > > > Jeff is seeing same one lenove laptop on 8998. > > > > Confirmed. > > > > > > > > 845 does not seem to have this issue and only thing I can see is > > > that on > > > sm8150 and 8998 we define reset as: > > > > > > resets = <&gcc GCC_UFS_BCR>; > > > reset-names = "rst"; > > > > > Hi Jeffrey and Vinod, > > Thanks for reporting this. May I know what kind of regression do you see on > 8150 and 8998? > BTW, do you have reset control for UFS PHY in your DT? > See 71278b058a9f8752e51030e363b7a7306938f64e. > > FYI, we use reset control on all of our platforms and it is > a must during our power up sequence. Yes we do have this and additionally both the DTS describe a 'rst' reset and this patch tries to use this. Can you please tell me which platform this was tested on how the reset was described in DT Thanks -- ~Vinod