From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F22B7C43603 for ; Tue, 17 Dec 2019 09:24:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7E0B207FF for ; Tue, 17 Dec 2019 09:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576574684; bh=6PIWuEhtUI+RkhpqPasL8EtWun3CNaybdET+BC/Pf1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=B+yRAvKjdHdgopzW7WMvNvLQ4FO+JNSLLhciVaYReYUPUvTLiUeUOz2DPHVzqsFV2 aqCuJW58K5A0VGPIq4dp/+F3fwk03O0IO7YrEX2fFlrtQRUQBClPctdAzzuB3NhsUe CJRTK/urOv+d4e1DmWoA49rmTiawpH6davS6xV0Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbfLQJYl (ORCPT ); Tue, 17 Dec 2019 04:24:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:48632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726787AbfLQJYl (ORCPT ); Tue, 17 Dec 2019 04:24:41 -0500 Received: from localhost (unknown [171.61.91.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 340EE20663; Tue, 17 Dec 2019 09:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576574680; bh=6PIWuEhtUI+RkhpqPasL8EtWun3CNaybdET+BC/Pf1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jBOtG8aieLBaEgJ6VXz/jZiiZBqVTdZo9U55uaWsKr/rMu+uoS9UYhhAyEbLmGRoX pGhT6zuLkRfycTJImZKGRzjNjGGrE78LzYGMnrXiKWWD4G6qcKbuB7czPQERTrEtZ0 FwGKXtjk9hyaSmN9OzhI5jQVwfaiSug4bA7HiWfk= Date: Tue, 17 Dec 2019 14:54:33 +0530 From: Vinod Koul To: cang@codeaurora.org Cc: Jeffrey Hugo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, Rajendra Nayak , linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Andy Gross , Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , "open list:ARM/QUALCOMM SUPPORT" , open list Subject: Re: [PATCH v5 2/7] scsi: ufs-qcom: Add reset control support for host controller Message-ID: <20191217092433.GN2536@vkoul-mobl> References: <1573798172-20534-1-git-send-email-cang@codeaurora.org> <1573798172-20534-3-git-send-email-cang@codeaurora.org> <20191216190415.GL2536@vkoul-mobl> <091562cbe7d88ca1c30638bc10197074@codeaurora.org> <20191217041342.GM2536@vkoul-mobl> <763d7b30593b31646f3c198c2be99671@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <763d7b30593b31646f3c198c2be99671@codeaurora.org> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Can, On 17-12-19, 15:10, cang@codeaurora.org wrote: > On 2019-12-17 12:13, Vinod Koul wrote: > > Hi Can, > > > > On 17-12-19, 08:37, cang@codeaurora.org wrote: > > > On 2019-12-17 03:12, Jeffrey Hugo wrote: > > > > On Mon, Dec 16, 2019 at 12:05 PM Vinod Koul wrote: > > > > > > > > > > Hi Can, > > > > > > > > > > On 14-11-19, 22:09, Can Guo wrote: > > > > > > Add reset control for host controller so that host controller can be reset > > > > > > as required in its power up sequence. > > > > > > > > > > I am seeing a regression on UFS on SM8150-mtp with this patch. I think > > > > > Jeff is seeing same one lenove laptop on 8998. > > > > > > > > Confirmed. > > > > > > > > > > > > > > 845 does not seem to have this issue and only thing I can see is > > > > > that on > > > > > sm8150 and 8998 we define reset as: > > > > > > > > > > resets = <&gcc GCC_UFS_BCR>; > > > > > reset-names = "rst"; > > > > > > > > > > > Hi Jeffrey and Vinod, > > > > > > Thanks for reporting this. May I know what kind of regression do you > > > see on > > > 8150 and 8998? > > > BTW, do you have reset control for UFS PHY in your DT? > > > See 71278b058a9f8752e51030e363b7a7306938f64e. > > > > > > FYI, we use reset control on all of our platforms and it is > > > a must during our power up sequence. > > > > Yes we do have this and additionally both the DTS describe a 'rst' reset > > and this patch tries to use this. > > > > Can you please tell me which platform this was tested on how the reset > > was described in DT > > > > Thanks > > Hi Vinod, > > If you are using the 8998's DT present on upstream, you may also need to > enable > device reset on your platform. (We usually do a device reset before call > ufshcd_hba_enable()) > Given that 845 works fine, it may be the difference you have with 845. 845 > has device > reset support ready in upstream code, you can check sdm845-mtp.dts. > It is same for 8150, which is a lack of device reset support in upstream > code base. I am using 8150mtp and you can see the DTS at [1] with this patch I get phy timeout error [ 2.532594] qcom-qmp-phy 1d87000.phy: phy initialization timed-out If i revert this patch the Timeout goes away. UFS node for this platform is enabled in [2] and [3] I did add the GPIO as well for testing but that doesnt work, only thing that makes it work is rename the reset line to something other that 'rst' I found that with this patch the reset is invoked twice, not sure why! The 845 does not define a reset 'rst' but both 8150 and 8998 define that! [1]: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/log/?h=for-next [2]: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=3834a2e92229ef26d30de28acb698b2b23d3e397 [3]: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=3e5bf28d2c3981f949e848eec8a60e0b9b61189d > > To enable UFS device reset, please see > 1. https://lore.kernel.org/linux-arm-msm/20190828191756.24312-4-bjorn.andersson@linaro.org/ > 2. 53a5372ce326116f3e3d3f1d701113b2542509f4 Yes both are added for UFS and I am testing with these.. > > FYI, I tested the patch on 8250 and its family platforms. In my build, I > ported > change in #2 to my code base (in your case, make change to > drivers/pinctrl/qcom/pinctrl-msm8998.c) and enable the GPIO in DT like > sdm845-mtp.dts Please see drivers/pinctrl/qcom/pinctrl-sm8150.c upstream > reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>; Yup, added: reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; -- ~Vinod