Re: [PATCH v6 6/9] scsi: ufs: Add inline encryption support to UFS

Christoph Hellwig
2020-02-05T18:07:18Z

On Fri, Jan 17, 2020 at 09:27:20PM -0800, Eric Biggers wrote:
> On Fri, Jan 17, 2020 at 05:58:08AM -0800, Christoph Hellwig wrote:
> > On Wed, Dec 18, 2019 at 06:51:33AM -0800, Satya Tangirala wrote:
> > > Wire up ufshcd.c with the UFS Crypto API, the block layer inline
> > > encryption additions and the keyslot manager.
> >
> > I think this patch should be merged into the previous patch, as the
> > previous one isn't useful without wiring it up.
> >
>
> Satya actually did this originally but then one of the UFS maintainers requested
> the separate patches for (1) new registers, (2) ufshcd-crypto, and (3) ufshcd.c:
> https://lore.kernel.org/linux-block/SN6PR04MB49259F70346E2055C9E0F401FC310@SN6PR04MB4925.namprd04.prod.outlook.com/
>
> So, he's not going to be able to make everyone happy :-)
>
> I personally would be fine with either way.

Oh well, the split between adding functions and callers is highly
unusual for Linux development. Adding the defines I can see,
especially if they are large (which these aren't). But you'll need
to get this accepted by the UFS folks, so I'll shut up now.