Re: [PATCH v6 2/9] block: Add encryption context to struct bio

Martin K. Petersen
2019-12-18T21:25:51Z

Darrick,

>> +#ifdef CONFIG_BLK_INLINE_ENCRYPTION
>> + struct bio_crypt_ctx *bi_crypt_context;
>> +#endif
>
> This grows struct bio even if we aren't actively using bi_crypt_context,
> and I thought Jens told us to stop making it bigger. :)

Yeah. Why not use the bio integrity plumbing? It was explicitly designed
to attach things to a bio and have them consumed by the device driver.

--
Martin K. Petersen Oracle Linux Engineering