Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives

Guenter Roeck
2020-01-08T15:32:30Z

Hi Martin,

On Tue, Jan 07, 2020 at 08:29:40PM -0500, Martin K. Petersen wrote:
>
> Guenter,
>
> > "scsi-8-140" is created by libsensors, so any change in that would
> > have to be made there, not in the kernel driver.
>
> Yes. Something like the patch below which will produce actual SCSI
> device instance names:
>
> drivetemp-scsi-7:0:29:0
> drivetemp-scsi-8:0:30:0
> drivetemp-scsi-8:0:15:0
> drivetemp-scsi-7:0:24:0
>
> Instead of the current:
>
> drivetemp-scsi-7-1d0
> drivetemp-scsi-8-1e0
> drivetemp-scsi-8-f0
> drivetemp-scsi-7-180
>
> Other question: Does hwmon have any notion of sensor topology? As I
> mentioned earlier, SCSI installations typically rely on SAF-TE or SES
> instead of the physical drive sensors. SES also includes monitoring of
> fans, power supplies, etc. And more importantly, it provides a
> representation of the location of a given component. E.g.: Tray number
> #4, disk drive bay #5.
>

Please go ahead and submit the patch for libsensors.

> So it would be helpful if libsensors had a way to represent sensors in a
> way that mimics the physical device layout reported by SES.
>

I guess it would be up to you to come up with a proposal.

Thanks,
Guenter