From: Deepak Ukey <deepak.ukey@microchip.com>
To: <linux-scsi@vger.kernel.org>
Cc: <Vasanthalakshmi.Tharmarajan@microchip.com>,
<Viswas.G@microchip.com>, <deepak.ukey@microchip.com>,
<jinpu.wang@profitbricks.com>, <martin.petersen@oracle.com>,
<yuuzheng@google.com>, <auradkar@google.com>,
<vishakhavc@google.com>, <bjashnani@google.com>,
<radha@google.com>, <akshatzen@google.com>
Subject: [PATCH V2 05/13] pm80xx : Support for char device.
Date: Fri, 17 Jan 2020 12:49:15 +0530 [thread overview]
Message-ID: <20200117071923.7445-6-deepak.ukey@microchip.com> (raw)
In-Reply-To: <20200117071923.7445-1-deepak.ukey@microchip.com>
From: Deepak Ukey <Deepak.Ukey@microchip.com>
Added the support to register the char device for pm80xx module so that
management utility fetch the different information from driver with the
help of IOCTL. Also added the IOCTL functionality to get driver info so
that management utility can fetch the information about driver like
driver name, driver major number, driver minor number and build number.
Signed-off-by: Deepak Ukey <deepak.ukey@microchip.com>
Signed-off-by: Viswas G <Viswas.G@microchip.com>
Signed-off-by: Radha Ramachandran <radha@google.com>
---
drivers/scsi/pm8001/pm8001_ctl.c | 148 ++++++++++++++++++++++++++++++++++++++
drivers/scsi/pm8001/pm8001_ctl.h | 33 +++++++++
drivers/scsi/pm8001/pm8001_init.c | 5 ++
drivers/scsi/pm8001/pm8001_sas.h | 6 ++
4 files changed, 192 insertions(+)
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index 7c6be2ec110d..69458b318a20 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -41,6 +41,7 @@
#include <linux/slab.h>
#include "pm8001_sas.h"
#include "pm8001_ctl.h"
+int pm80xx_major = -1;
/* scsi host attributes */
@@ -845,3 +846,150 @@ struct device_attribute *pm8001_host_attrs[] = {
NULL,
};
+/*
+ * pm8001_open - open the configuration file
+ * @inode: inode being opened
+ * @file: file handle attached
+ *
+ * Called when the configuration device is opened. Does the needed
+ * set up on the handle and then returns
+ *
+ */
+static int pm8001_open(struct inode *inode, struct file *file)
+{
+ struct pm8001_hba_info *pm8001_ha;
+ unsigned int minor_number = iminor(inode);
+ int err = -ENODEV;
+
+ list_for_each_entry(pm8001_ha, &hba_list, list) {
+ if (pm8001_ha->id == minor_number) {
+ file->private_data = pm8001_ha;
+ err = 0;
+ break;
+ }
+ }
+
+ return err;
+}
+
+/**
+ * pm8001_close - close the configuration file
+ * @inode: inode being opened
+ * @file: file handle attached
+ *
+ * Called when the configuration device is closed. Does the needed
+ * set up on the handle and then returns
+ *
+ */
+static int pm8001_close(struct inode *inode, struct file *file)
+{
+ return 0;
+}
+
+static long pm8001_info_ioctl(struct pm8001_hba_info *pm8001_ha,
+ unsigned long arg)
+{
+ u32 ret = 0;
+ struct ioctl_info_buffer info_buf;
+
+ strcpy(info_buf.information.sz_name, DRV_NAME);
+
+ info_buf.information.usmajor_revision = DRV_MAJOR;
+ info_buf.information.usminor_revision = DRV_MINOR;
+ info_buf.information.usbuild_revision = DRV_BUILD;
+ if (pm8001_ha->chip_id == chip_8001) {
+ info_buf.information.maxoutstandingIO =
+ pm8001_ha->main_cfg_tbl.pm8001_tbl.max_out_io;
+ info_buf.information.maxdevices =
+ (pm8001_ha->main_cfg_tbl.pm8001_tbl.max_sgl >> 16) &
+ 0xFFFF;
+ } else {
+ info_buf.information.maxoutstandingIO =
+ pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_out_io;
+ info_buf.information.maxdevices =
+ (pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_sgl >> 16) &
+ 0xFFFF;
+ }
+ info_buf.header.return_code = ADPT_IOCTL_CALL_SUCCESS;
+
+ if (copy_to_user((void *)arg, (void *)&info_buf,
+ sizeof(struct ioctl_info_buffer))) {
+ ret = ADPT_IOCTL_CALL_FAILED;
+ }
+ return ret;
+}
+
+/**
+ * pm8001_ioctl - pm8001 configuration request
+ * @inode: inode of device
+ * @file: file handle
+ * @cmd: ioctl command code
+ * @arg: argument
+ *
+ * Handles a configuration ioctl.
+ *
+ */
+static long pm8001_ioctl(struct file *file,
+ unsigned int cmd, unsigned long arg)
+{
+ u32 ret = -EACCES;
+ struct pm8001_hba_info *pm8001_ha;
+ struct ioctl_header header;
+
+ pm8001_ha = file->private_data;
+
+ switch (cmd) {
+ case ADPT_IOCTL_INFO:
+ ret = pm8001_info_ioctl(pm8001_ha, arg);
+ break;
+ default:
+ ret = ADPT_IOCTL_CALL_INVALID_CODE;
+ }
+
+ if (ret == 0)
+ return ret;
+ header.return_code = ret;
+ ret = -EACCES;
+ if (copy_to_user((void *)arg, (void *)&header,
+ sizeof(struct ioctl_header))) {
+ PM8001_FAIL_DBG(pm8001_ha,
+ pm8001_printk("copy_to_user failed\n"));
+ }
+ return ret;
+}
+
+static const struct file_operations pm8001_fops = {
+ .owner = THIS_MODULE,
+ .open = pm8001_open,
+ .release = pm8001_close,
+ .unlocked_ioctl = pm8001_ioctl,
+};
+
+/**
+ * pm8001_setup_chrdev - register char device
+ * Return value:
+ * 0 in case of success, otherwise non-zero value
+ */
+int pm8001_setup_chrdev(void)
+{
+ pm80xx_major = register_chrdev(0, DRV_NAME, &pm8001_fops);
+ if (pm80xx_major < 0) {
+ pr_warn("pm8001: unable to register %s device.\n",
+ DRV_NAME);
+ return pm80xx_major;
+ }
+ return 0;
+}
+
+/**
+ * pm8001_release_chrdev - unregisters per-adapter management interface
+ * Return value:
+ * none
+ */
+void pm8001_release_chrdev(void)
+{
+ if (pm80xx_major > -1) {
+ unregister_chrdev(pm80xx_major, DRV_NAME);
+ pm80xx_major = -1;
+ }
+}
diff --git a/drivers/scsi/pm8001/pm8001_ctl.h b/drivers/scsi/pm8001/pm8001_ctl.h
index d0d43a250b9e..f0f8b1deae27 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.h
+++ b/drivers/scsi/pm8001/pm8001_ctl.h
@@ -59,5 +59,38 @@
#define SYSFS_OFFSET 1024
#define PM80XX_IB_OB_QUEUE_SIZE (32 * 1024)
#define PM8001_IB_OB_QUEUE_SIZE (16 * 1024)
+
+#define ADPT_IOCTL_CALL_SUCCESS 0x00
+#define ADPT_IOCTL_CALL_FAILED 0x01
+#define ADPT_IOCTL_CALL_INVALID_CODE 0x03
+
+struct ioctl_header {
+ u32 io_controller_num;
+ u32 length;
+ u32 return_code;
+ u32 timeout;
+ u16 direction;
+};
+
+struct ioctl_drv_info {
+ u8 sz_name[64];
+ u16 usmajor_revision;
+ u16 usminor_revision;
+ u16 usbuild_revision;
+ u16 reserved0;
+ u32 maxdevices;
+ u32 maxoutstandingIO;
+ u32 reserved[16];
+};
+
+struct ioctl_info_buffer {
+ struct ioctl_header header;
+ struct ioctl_drv_info information;
+};
+
+#define ADPT_IOCTL_INFO _IOR(ADPT_MAGIC_NUMBER, 0, struct ioctl_info_buffer *)
+
+#define ADPT_MAGIC_NUMBER 'm'
+
#endif /* PM8001_CTL_H_INCLUDED */
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 775517f9b39d..25e74f1dbd0c 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -1421,6 +1421,9 @@ static int __init pm8001_init(void)
pm8001_stt = sas_domain_attach_transport(&pm8001_transport_ops);
if (!pm8001_stt)
goto err_wq;
+ rc = pm8001_setup_chrdev();
+ if (rc)
+ goto err_ctl;
rc = pci_register_driver(&pm8001_pci_driver);
if (rc)
goto err_tp;
@@ -1428,6 +1431,8 @@ static int __init pm8001_init(void)
err_tp:
sas_release_transport(pm8001_stt);
+err_ctl:
+ pm8001_release_chrdev();
err_wq:
destroy_workqueue(pm8001_wq);
err:
diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h
index 93438c8f67da..479aac34d7cc 100644
--- a/drivers/scsi/pm8001/pm8001_sas.h
+++ b/drivers/scsi/pm8001/pm8001_sas.h
@@ -59,6 +59,9 @@
#define DRV_NAME "pm80xx"
#define DRV_VERSION "0.1.39"
+#define DRV_MAJOR 1
+#define DRV_MINOR 3
+#define DRV_BUILD 0
#define PM8001_FAIL_LOGGING 0x01 /* Error message logging */
#define PM8001_INIT_LOGGING 0x02 /* driver init logging */
#define PM8001_DISC_LOGGING 0x04 /* discovery layer logging */
@@ -745,6 +748,9 @@ ssize_t pm8001_get_gsm_dump(struct device *cdev, u32, char *buf);
/* ctl shared API */
extern struct device_attribute *pm8001_host_attrs[];
+int pm8001_setup_chrdev(void);
+void pm8001_release_chrdev(void);
+
static inline void
pm8001_ccb_task_free_done(struct pm8001_hba_info *pm8001_ha,
struct sas_task *task, struct pm8001_ccb_info *ccb,
--
2.16.3
next prev parent reply other threads:[~2020-01-17 7:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 7:19 [PATCH V2 00/13] pm80xx : Updates for the driver version 0.1.39 Deepak Ukey
2020-01-17 7:19 ` [PATCH V2 01/13] pm80xx : Increase request sg length Deepak Ukey
2020-01-17 14:08 ` Jinpu Wang
2020-01-17 15:50 ` Deepak.Ukey
2020-01-17 15:53 ` Jinpu Wang
2020-01-20 4:20 ` Deepak.Ukey
2020-01-20 8:47 ` Jinpu Wang
2020-01-29 9:02 ` Deepak.Ukey
2020-01-17 7:19 ` [PATCH V2 02/13] pm80xx : Deal with kexec reboots Deepak Ukey
2020-01-17 7:19 ` [PATCH V2 03/13] pm80xx : Free the tag when mpi_set_phy_profile_resp is received Deepak Ukey
2020-01-17 7:19 ` [PATCH V2 04/13] pm80xx : Cleanup initialization loading fail path Deepak Ukey
2020-01-17 7:19 ` Deepak Ukey [this message]
2020-01-17 14:15 ` [PATCH V2 05/13] pm80xx : Support for char device Jinpu Wang
2020-01-21 0:24 ` Martin K. Petersen
2020-01-21 5:33 ` Deepak.Ukey
2020-01-21 12:39 ` John Garry
2020-01-22 8:50 ` Deepak.Ukey
2020-01-22 12:38 ` John Garry
2020-01-28 9:43 ` Deepak.Ukey
2020-03-11 17:08 ` Jinpu Wang
2020-03-11 22:13 ` Douglas Gilbert
2020-03-12 8:49 ` Jinpu Wang
2020-03-12 10:58 ` John Garry
2020-03-16 6:22 ` Deepak.Ukey
2020-01-17 7:19 ` [PATCH V2 06/13] pm80xx : sysfs attribute for number of phys Deepak Ukey
2020-01-17 14:21 ` Jinpu Wang
2020-01-20 4:50 ` Deepak.Ukey
2020-01-21 7:55 ` Jinpu Wang
2020-01-17 7:19 ` [PATCH V2 07/13] pm80xx : IOCTL functionality to get phy status Deepak Ukey
2020-01-17 14:35 ` Jinpu Wang
2020-01-17 7:19 ` [PATCH V2 08/13] pm80xx : IOCTL functionality to get phy error Deepak Ukey
2020-01-17 7:19 ` [PATCH V2 09/13] pm80xx : IOCTL functionality for GPIO Deepak Ukey
2020-01-17 7:19 ` [PATCH V2 10/13] pm80xx : IOCTL functionality for SGPIO Deepak Ukey
2020-01-22 8:59 ` Jinpu Wang
2020-01-17 7:19 ` [PATCH V2 11/13] pm80xx : sysfs attribute for non fatal dump Deepak Ukey
2020-01-17 14:26 ` Jinpu Wang
2020-01-17 7:19 ` [PATCH V2 12/13] pm80xx : Introduce read and write length for IOCTL payload structure Deepak Ukey
2020-01-17 7:19 ` [PATCH V2 13/13] pm80xx : IOCTL functionality for TWI device Deepak Ukey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117071923.7445-6-deepak.ukey@microchip.com \
--to=deepak.ukey@microchip.com \
--cc=Vasanthalakshmi.Tharmarajan@microchip.com \
--cc=Viswas.G@microchip.com \
--cc=akshatzen@google.com \
--cc=auradkar@google.com \
--cc=bjashnani@google.com \
--cc=jinpu.wang@profitbricks.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=radha@google.com \
--cc=vishakhavc@google.com \
--cc=yuuzheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox