From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE779C33CB1 for ; Sat, 18 Jan 2020 05:27:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D01424683 for ; Sat, 18 Jan 2020 05:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579325248; bh=Su46dTvr6LjbK97+KpEmyjmd9MCvkLqGMyfTWsk56iA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=x4q2/ccT52PS4yih8VqzWFG/X+hDRrn2+7k2z7u2HK/z8Gtc26oZg8I9neRzqASB0 inpNxcMmscjkEJycC1W8Or7qYVn2G+7ygBT25fhhjLDg3mwpLltzmsxnnQkInh0m8o XfLObzTb8E1n1r9Ubq0nXbgd0vbnU9A6TPiNAmmw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbgARF11 (ORCPT ); Sat, 18 Jan 2020 00:27:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:45494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgARF11 (ORCPT ); Sat, 18 Jan 2020 00:27:27 -0500 Received: from sol.localdomain (unknown [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BAD820748; Sat, 18 Jan 2020 05:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579325246; bh=Su46dTvr6LjbK97+KpEmyjmd9MCvkLqGMyfTWsk56iA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MFIjHfQvc0kv0Ya/20xHIdfC6o2bof5u5eJqd9/VwJTPA9YcLj8x1k0vYihsxVLtW t1a4NJrrFEzd69isqDax6lXJWaafYGXjS953uoZ94rGPWCAsJxRPKpvc74B6onf6sr FOJFhvTtB6DdCiGovue/tD35DIjmdgbzT+VmQa00= Date: Fri, 17 Jan 2020 21:27:20 -0800 From: Eric Biggers To: Christoph Hellwig Cc: Satya Tangirala , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Barani Muthukumaran , Kuohong Wang , Kim Boojin Subject: Re: [PATCH v6 6/9] scsi: ufs: Add inline encryption support to UFS Message-ID: <20200118052720.GD3290@sol.localdomain> References: <20191218145136.172774-1-satyat@google.com> <20191218145136.172774-7-satyat@google.com> <20200117135808.GB5670@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117135808.GB5670@infradead.org> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Fri, Jan 17, 2020 at 05:58:08AM -0800, Christoph Hellwig wrote: > On Wed, Dec 18, 2019 at 06:51:33AM -0800, Satya Tangirala wrote: > > Wire up ufshcd.c with the UFS Crypto API, the block layer inline > > encryption additions and the keyslot manager. > > I think this patch should be merged into the previous patch, as the > previous one isn't useful without wiring it up. > Satya actually did this originally but then one of the UFS maintainers requested the separate patches for (1) new registers, (2) ufshcd-crypto, and (3) ufshcd.c: https://lore.kernel.org/linux-block/SN6PR04MB49259F70346E2055C9E0F401FC310@SN6PR04MB4925.namprd04.prod.outlook.com/ So, he's not going to be able to make everyone happy :-) I personally would be fine with either way. - Eric