Re: [PATCH 2/6] scsi: remove .for_blk_mq

John Garry
2020-01-20T10:17:46Z

On 19/01/2020 07:14, Ming Lei wrote:
> No one use it any more, so remove the flag.
>
> Cc: Sathya Prakash <sathya.prakash@broadcom.com>
> Cc: Chaitra P B <chaitra.basappa@broadcom.com>
> Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
> Cc: Kashyap Desai <kashyap.desai@broadcom.com>
> Cc: Sumit Saxena <sumit.saxena@broadcom.com>
> Cc: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>,
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Bart Van Assche <bart.vanassche@wdc.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>

I think that we can also delete drivers/scsi/scsi.c:scsi_use_blk_mq.

IIRC, a patch was already sent for that but never picked up.

Thanks,
John

> ---
> drivers/scsi/virtio_scsi.c | 1 -
> include/scsi/scsi_host.h | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index bfec84aacd90..0e0910c5b942 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -742,7 +742,6 @@ static struct scsi_host_template virtscsi_host_template = {
> .dma_boundary = UINT_MAX,
> .map_queues = virtscsi_map_queues,
> .track_queue_depth = 1,
> - .force_blk_mq = 1,
> };
>
> #define virtscsi_config_get(vdev, fld) \
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index f577647bf5f2..7a97fb8104cf 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -426,9 +426,6 @@ struct scsi_host_template {
> /* True if the controller does not support WRITE SAME */
> unsigned no_write_same:1;
>
> - /* True if the low-level driver supports blk-mq only */
> - unsigned force_blk_mq:1;
> -
> /*
> * Countdown for host blocking with no commands outstanding.
> */
>