Re: [PATCH 1/6] scsi: mpt3sas: don't use .device_busy in device reset routine

Bart Van Assche
2020-01-19T20:29:18Z

On 2020-01-18 23:14, Ming Lei wrote:
> Cc: Bart Van Assche <bart.vanassche@wdc.com>

As one can see in the .mailmap file in the kernel tree I use my @acm.org
email address for kernel contributions. The above email address is no
longer valid since I left WDC more than a year ago. This is something I
have mentioned before. See also
https://lore.kernel.org/linux-scsi/55c68a97-4393-fa63-e2da-d41a48237f96@acm.org/

> +static bool scsi_device_check_in_flight(struct request *rq, void *data,
> + bool reserved)
> +{
> + struct device_busy *busy = data;
> + struct scsi_cmnd *cmd = blk_mq_rq_to_pdu(rq);
> +
> + if (test_bit(SCMD_STATE_INFLIGHT, &cmd->state) && cmd->device ==
> + busy->dev)
> + (busy->cnt)++;
> +
> + return true;
> +}

scsi_host_check_in_flight() is almost identical to the above function.
Has it been considered to merge these two functions into a single
function? Same comment for scsi_host_busy() and scsih_dev_busy().

Thanks,

Bart.