From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: bvanassche@acm.org, James Smart <jsmart2021@gmail.com>
Subject: [PATCH v3 3/3] scsi: add shost attribute to set max queue depth on all devices on the shost
Date: Fri, 24 Jan 2020 15:01:15 -0800 [thread overview]
Message-ID: <20200124230115.14562-4-jsmart2021@gmail.com> (raw)
In-Reply-To: <20200124230115.14562-1-jsmart2021@gmail.com>
This patch adds an shost attribute, max_device_queue_depth, that will
cycle through all devices on the shost and change their current and max
queue depth to the new value.
Signed-off-by: James Smart <jsmart2021@gmail.com>
---
v3:
use kstrtouint
specify permissions in octl, not by mnemonic
remove unnecessary parens
---
drivers/scsi/scsi_sysfs.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index d4e9ad9a6f18..98dbbfb6397b 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -368,6 +368,26 @@ store_shost_eh_deadline(struct device *dev, struct device_attribute *attr,
static DEVICE_ATTR(eh_deadline, S_IRUGO | S_IWUSR, show_shost_eh_deadline, store_shost_eh_deadline);
+static ssize_t
+store_host_max_device_queue_depth(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ struct Scsi_Host *shost = class_to_shost(dev);
+ unsigned int depth;
+ int retval;
+
+ retval = kstrtouint(buf, 10, &depth);
+ if (retval)
+ return -EINVAL;
+
+ retval = shost_change_max_queue_depths(shost, depth);
+
+ return retval < 0 ? retval : count;
+}
+
+static DEVICE_ATTR(max_device_queue_depth, 0200, NULL,
+ store_host_max_device_queue_depth);
+
shost_rd_attr(unique_id, "%u\n");
shost_rd_attr(cmd_per_lun, "%hd\n");
shost_rd_attr(can_queue, "%hd\n");
@@ -411,6 +431,7 @@ static struct attribute *scsi_sysfs_shost_attrs[] = {
&dev_attr_prot_guard_type.attr,
&dev_attr_host_reset.attr,
&dev_attr_eh_deadline.attr,
+ &dev_attr_max_device_queue_depth.attr,
NULL
};
--
2.13.7
next prev parent reply other threads:[~2020-01-24 23:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 23:01 [PATCH v3 0/3] scsi: add attribute to set lun queue depth on all luns on shost James Smart
2020-01-24 23:01 ` [PATCH v3 1/3] scsi: refactor sdev lun queue depth setting via sysfs James Smart
2020-01-25 5:54 ` Bart Van Assche
2020-01-24 23:01 ` [PATCH v3 2/3] scsi: add shost helper to set max queue depth on all of its devices James Smart
2020-01-25 5:53 ` Bart Van Assche
2020-01-24 23:01 ` James Smart [this message]
2020-01-25 5:51 ` [PATCH v3 3/3] scsi: add shost attribute to set max queue depth on all devices on the shost Bart Van Assche
2020-02-05 2:56 ` [PATCH v3 0/3] scsi: add attribute to set lun queue depth on all luns on shost Martin K. Petersen
2020-02-05 18:57 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124230115.14562-4-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox