From: Ming Lei <ming.lei@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Omar Sandoval <osandov@fb.com>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
"Ewan D . Milne" <emilne@redhat.com>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bart.vanassche@wdc.com>
Subject: Re: [PATCH 10/10] scsi: replace sdev->device_busy with sbitmap
Date: Fri, 14 Feb 2020 17:16:56 +0800 [thread overview]
Message-ID: <20200214091656.GA777@ming.t460p> (raw)
In-Reply-To: <202002140428.063yIjwM%lkp@intel.com>
On Fri, Feb 14, 2020 at 04:22:08AM +0800, kbuild test robot wrote:
> Hi Ming,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on scsi/for-next]
> [also build test WARNING on mkp-scsi/for-next block/for-next v5.6-rc1 next-20200213]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Ming-Lei/scsi-tracking-device-queue-depth-via-sbitmap/20200213-215727
> base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.5.0 make.cross ARCH=arm
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> In file included from drivers/message/fusion/mptbase.h:839:0,
> from drivers/message/fusion/mptsas.c:63:
> drivers/message/fusion/mptsas.c: In function 'mptsas_send_link_status_event':
> drivers/message/fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message/fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message/fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message/fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message/fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message/fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message/fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message/fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message/fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message/fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message/fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message/fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> --
> In file included from drivers/message//fusion/mptbase.h:839:0,
> from drivers/message//fusion/mptsas.c:63:
> drivers/message//fusion/mptsas.c: In function 'mptsas_send_link_status_event':
> drivers/message//fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message//fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message//fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message//fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message//fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message//fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message//fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message//fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message//fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
> ^~~~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:26: error: 'struct scsi_device' has no member named 'device_busy'; did you mean 'device_blocked'?
> atomic_read(&sdev->device_busy)));
> ^
> drivers/message//fusion/mptdebug.h:72:3: note: in definition of macro 'MPT_CHECK_LOGGING'
> CMD; \
> ^~~
> drivers/message//fusion/mptsas.c:3755:7: note: in expansion of macro 'devtprintk'
> devtprintk(ioc,
> ^~~~~~~~~~
> include/linux/compiler.h:269:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> >> arch/arm/include/asm/atomic.h:27:24: note: in expansion of macro 'READ_ONCE'
> #define atomic_read(v) READ_ONCE((v)->counter)
> ^~~~~~~~~
> drivers/message//fusion/mptsas.c:3759:7: note: in expansion of macro 'atomic_read'
> atomic_read(&sdev->device_busy)));
Hello,
Thanks for the report.
Looks miss this non-scsi directory, will fix it in V2 after getting
some feedback.
Thank,
Ming
prev parent reply other threads:[~2020-02-14 9:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 12:11 [PATCH 00/10] scsi: tracking device queue depth via sbitmap Ming Lei
2020-02-11 12:11 ` [PATCH 01/10] sbitmap: maintain allocation round_robin in sbitmap Ming Lei
2020-04-14 6:04 ` Hannes Reinecke
2020-02-11 12:11 ` [PATCH 02/10] sbitmap: add helpers for updating allocation hint Ming Lei
2020-04-14 6:05 ` Hannes Reinecke
2020-02-11 12:11 ` [PATCH 03/10] sbitmap: remove sbitmap_clear_bit_unlock Ming Lei
2020-04-14 6:06 ` Hannes Reinecke
2020-02-11 12:11 ` [PATCH 04/10] sbitmap: move allocation hint into sbitmap Ming Lei
2020-02-11 12:11 ` [PATCH 05/10] sbitmap: export sbitmap_weight Ming Lei
2020-02-11 12:11 ` [PATCH 06/10] sbitmap: add helper of sbitmap_calculate_shift Ming Lei
2020-02-11 12:11 ` [PATCH 07/10] blk-mq: return budget token from .get_budget callback Ming Lei
2020-02-11 12:11 ` [PATCH 08/10] blk-mq: pass budget token to dirver via blk_mq_queue_data Ming Lei
2020-02-11 12:11 ` [PATCH 09/10] scsi: add scsi_device_busy() to read sdev->device_busy Ming Lei
2020-02-11 12:11 ` [PATCH 10/10] scsi: replace sdev->device_busy with sbitmap Ming Lei
2020-02-13 20:18 ` kbuild test robot
2020-02-13 20:22 ` kbuild test robot
2020-02-14 9:16 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214091656.GA777@ming.t460p \
--to=ming.lei@redhat.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=chaitra.basappa@broadcom.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=kashyap.desai@broadcom.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=osandov@fb.com \
--cc=sathya.prakash@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox