From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DB3C10DCE for ; Fri, 13 Mar 2020 14:55:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CEF2206FA for ; Fri, 13 Mar 2020 14:55:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yadro.com header.i=@yadro.com header.b="DWovb7TH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726216AbgCMOzs (ORCPT ); Fri, 13 Mar 2020 10:55:48 -0400 Received: from mta-02.yadro.com ([89.207.88.252]:53572 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726528AbgCMOzs (ORCPT ); Fri, 13 Mar 2020 10:55:48 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id E473C41268; Fri, 13 Mar 2020 14:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=mta-01; t=1584111344; x=1585925745; bh=U9NVbaZ1OCLKM+BlurQuYA0WSX55eAwIY04eh2Wn3ec=; b= DWovb7THatJXihNmcr73W/3KypFXxLFhLX2KCnFED4aovM7tiCX3gadiO1ifOaFO +Vew1aWwzwVJu6T7DO4a7BYgmJh3vjqIbDZfR8VaDP0bwGyYt8AyTbFWpAhZZj5R ocXhcZMhymES3/9ab0c3GXjgxBMmj80ev9Dn4yRb7FY= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fZq3v-MTTu1i; Fri, 13 Mar 2020 17:55:44 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 78895411FA; Fri, 13 Mar 2020 17:55:43 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Fri, 13 Mar 2020 17:55:43 +0300 Date: Fri, 13 Mar 2020 17:55:42 +0300 From: Roman Bolshakov To: CC: "Martin K. Petersen" , Himanshu Madhani , Quinn Tran , Hannes Reinecke , Bart Van Assche , Daniel Wagner , James Bottomley , Subject: Re: [PATCH v2 2/3] scsi: qla2xxx: don't shut down firmware before closing sessions Message-ID: <20200313145542.GA42639@SPB-NB-133.local> References: <20200205214422.3657-1-mwilck@suse.com> <20200205214422.3657-3-mwilck@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200205214422.3657-3-mwilck@suse.com> X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Feb 05, 2020 at 10:44:21PM +0100, mwilck@suse.com wrote: > From: Martin Wilck > > Since 45235022da99, the firmware is shut down early in the controller > shutdown process. This causes commands sent to the firmware (such as LOGO) > to hang forever. Eventually one or more timeouts will be triggered. > Move the stopping of the firmware until after sessions have terminated. > > Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down chip") > Signed-off-by: Martin Wilck > --- > drivers/scsi/qla2xxx/qla_os.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > Hi Martin, Reviewed-by: Roman Bolshakov BTW, I think qla_nvme_delete() should be moved up to split the function into two parts: * session/port cleanup * chip shutdown Although invocation of the function after chip shutdown has no functional implications at the moment. Best regards, Roman