Re: [PATCH v3 13/31] elx: libefc: Fabric node state machine interfaces

James Smart
2020-04-23T01:38:11Z

On 4/15/2020 11:37 PM, Hannes Reinecke wrote:
> What is going on here?
> Why do you declare all function as 'void *', but then continue to return
> only NULL pointer?
>
> Is this some weird API logic or are these functions being fleshed out in
> later patches to return something else but NULL?
>
> But as it stands I would recommend to move all of these functions to
> simple 'void' functions, and updating the function prototypes once they
> can return anything else than 'NULL'.
>
> Cheers,
>
> Hannes

We will convert to void functions. Agree with your comments.

-- james