Re: [PATCH v3 30/31] elx: efct: Add Makefile and Kconfig for efct driver

Daniel Wagner
2020-04-16T13:16:09Z

On Sat, Apr 11, 2020 at 08:33:02PM -0700, James Smart wrote:
> This patch completes the efct driver population.
>
> This patch adds driver definitions for:
> Adds the efct driver Kconfig and Makefiles
>
> Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
>
> ---
> v3:
> Use SPDX license
> Remove utils.c from makefile
> ---
> drivers/scsi/elx/Kconfig | 9 +++++++++
> drivers/scsi/elx/Makefile | 18 ++++++++++++++++++
> 2 files changed, 27 insertions(+)
> create mode 100644 drivers/scsi/elx/Kconfig
> create mode 100644 drivers/scsi/elx/Makefile
>
> diff --git a/drivers/scsi/elx/Kconfig b/drivers/scsi/elx/Kconfig
> new file mode 100644
> index 000000000000..831daea7a951
> --- /dev/null
> +++ b/drivers/scsi/elx/Kconfig
> @@ -0,0 +1,9 @@
> +config SCSI_EFCT
> + tristate "Emulex Fibre Channel Target"
> + depends on PCI && SCSI
> + depends on TARGET_CORE
> + depends on SCSI_FC_ATTRS
> + select CRC_T10DIF
> + help
> + The efct driver provides enhanced SCSI Target Mode
> + support for specific SLI-4 adapters.

The help text could be more verbose. The rest looks good.

Reviewed-by: Daniel Wagner <dwagner@suse.de>