Re: [PATCH v3 22/31] elx: efct: Extended link Service IO handling

James Smart
2020-04-23T03:30:49Z

On 4/16/2020 12:58 AM, Hannes Reinecke wrote:
...
> That is a bit strange.
> Sending a response can fail, but (apparently) sending a request cannot;
> at the very least you don't have (or check) the return value from the
> send request.
>
> Some intricate scheme I've missed?
>

The send_request fully handles the failure case, which ends up calling
the request completion callback with an error status, before
send_request returns to the callee. Not handled that way with the
response. The response routine handles the error.

Agree with your other comments and will address them.
Same thing for comments on patches 19 and 20.

-- james