Re: [PATCH v3 05/31] elx: libefc_sli: Populate and post different WQEs

James Smart
2020-04-22T05:08:57Z

On 4/15/2020 7:34 AM, Daniel Wagner wrote:
...
>> +/* Write an ABORT_WQE work queue entry */
>> +int
>> +sli_abort_wqe(struct sli4 *sli4, void *buf, size_t size,
>> + enum sli4_abort_type type, bool send_abts, u32 ids,
>> + u32 mask, u16 tag, u16 cq_id)
>> +{
>> + struct sli4_abort_wqe *abort = buf;
>> +
>> + memset(buf, 0, size);
>
> Is 'size' expected to be equal to the size of 'struct sli4_abort_wqe'?
> Or could it be bigger? In case 'size' can be bigger than 'abort', do
> you need to clear the complete buffer, or would it be enough to clear
> only the size of 'abort'?

'buf' represents the abort WQE. Size will be the WQE size. Yeah, this is
unclear. Will fix up the coding to make the actions explicit and clear.

Agree with other comments and will address them.

-- james