Re: [PATCH v3 25/31] elx: efct: Hardware IO submission routines

James Smart
2020-04-23T03:37:42Z

On 4/16/2020 5:45 AM, Daniel Wagner wrote:
> On Thu, Apr 16, 2020 at 10:10:18AM +0200, Hannes Reinecke wrote:
>>> + switch (type) {
>>> + case EFCT_HW_ELS_REQ:
>>> + if (!send ||
>>> + sli_els_request64_wqe(&hw->sli, io->wqe.wqebuf,
>>> + hw->sli.wqe_size, io->sgl,
>>> + *((u8 *)send->virt),
>>> + len, receive->size,
>>> + iparam->els.timeout,
>>> + io->indicator, io->reqtag,
>>> + SLI4_CQ_DEFAULT, rnode->indicator,
>>> + rnode->sport->indicator,
>>> + rnode->attached, rnode->fc_id,
>>> + rnode->sport->fc_id)) {
>>> + efc_log_err(hw->os, "REQ WQE error\n");
>>> + rc = EFCT_HW_RTN_ERROR;
>>> + }
>>> + break;
>>
>> I did mention several times that I'm not a big fan of overly long argument
>> lists.
>> Can't you pass in 'io' and 'rnode' directly and cut down on the number of
>> arguments?
>
> Yes, please!
>

Agree, and agree with both Hannes' and your comments on this patch.

Daniel - also agree with your comments on patches 16 through 23.

Thanks

-- james