Re: [PATCH v3 14/31] elx: libefc: FC node ELS and state handling

James Smart
2020-04-23T02:50:12Z

On 4/15/2020 11:56 AM, Daniel Wagner wrote:
...
>> + switch (evt) {
>> + case EFC_EVT_ENTER:
>> + efc_node_hold_frames(node);
>> + /* Fall through */
>
> fallthrough;
>

Actually the patches that went in for -Wimplicit-fallthrough wants
/* fall through */

Other comments are fine and we'll address them.
BTW: Same goes for comments on patches 3, 7, 8, 9, 10, and 11.

>
> I run out of steam and thus stop here...
>
> Thanks,
> Daniel
>

I understand. Regardless, thank you for the time and effort on this.

-- james