Re: [PATCH v3 15/31] elx: efct: Data structures and defines for hw operations

James Smart
2020-04-23T02:59:51Z

On 4/16/2020 12:22 AM, Daniel Wagner wrote:
...
>> +/**
>> + * HW IO object.
>> + *
>> + * Stores the per-IO information necessary
>> + * for both the lower (SLI) and upper
>> + * layers (efct).
>> + */
>> +struct efct_hw_io {
>> + /* Owned by HW */
>
> What are the rules? Live time properties?
>
>> +
>> + /* reference counter and callback function */
>
> Make kerneldoc out of it?
>

I'll see if there's something we can write about it.

Agree with rest of comments.

-- james