Re: [PATCH v3 02/31] elx: libefc_sli: SLI Descriptors and Queue entries

James Smart
2020-04-22T04:41:46Z

On 4/14/2020 11:02 AM, Daniel Wagner wrote:
> Hi,
>
> On Sat, Apr 11, 2020 at 08:32:34PM -0700, James Smart wrote:
>> This patch continues the libefc_sli SLI-4 library population.
>>
>> This patch add SLI-4 Data structures and defines for:
>> - Buffer Descriptors (BDEs)
>> - Scatter/Gather List elements (SGEs)
>> - Queues and their Entry Descriptions for:
>> Event Queues (EQs), Completion Queues (CQs),
>> Receive Queues (RQs), and the Mailbox Queue (MQ).
>
> There are a definitions which are not used at all,
> e.g. DISEED_SGE_OP_RX_VALUE, sli4_acqe_e, sli4_acqe_event_code,
> etc. What are the plans with those?
>

When defining adapter interfaces, the interface is usually defined in
its entirety, whether fully used or not. Not only is it not always
clear what will be used when first added, but it seems cleaner to review
for correctness (comparing 1:1 with a hw spec vs 1sy-2sy vs N in spec).
In the case of several of the items, there will be future features (DIF
support) folded in that will utilize most of the definitions.

I know it's not as clean as "only define what is used", but I would
prefer to handle hw this way.

Agree with the rest of the comments and will address.

-- james