Re: [PATCH v3 01/31] elx: libefc_sli: SLI-4 register offsets and field definitions

James Smart
2020-04-22T04:29:01Z

On 4/14/2020 8:23 AM, Daniel Wagner wrote:
> Hi James,
>
> On Sat, Apr 11, 2020 at 08:32:33PM -0700, James Smart wrote:
>> This is the initial patch for the new Emulex target mode SCSI
>> driver sources.
>>
>> This patch:
>> - Creates the new Emulex source level directory drivers/scsi/elx
>> and adds the directory to the MAINTAINERS file.
>
> I would drop this. It's clear from the diff stat.
>
>> - Creates the first library subdirectory drivers/scsi/elx/libefc_sli.
>> This library is a SLI-4 interface library.
>
> Instead saying what this patch does, it would be better the explain
> why it structured this way.

Ok. I will see what I can come up with.

>
...
>
> BTW, why is it called SLI4_BMBX_WRITE_HI and not just SLI4_BMBX_HI?
> Because below with the doorbell registers there is a different pattern.

Because the semantics of the BMBX register involve writing it (as a u32)
once for the high address bits and a second time for the low address
bits. The format is slightly different on each write.

I'll see how to comment this and clarify. inlines will help.

Agree with the rest of the comments and will clarify

-- james