Re: [PATCH v3 09/31] elx: libefc: Emulex FC discovery library APIs and definitions

Hannes Reinecke
2020-04-15T12:41:52Z

On 4/12/20 5:32 AM, James Smart wrote:
> This patch continues the libefc library population.
>
> This patch adds library interface definitions for:
> - SLI/Local FC port objects
> - efc_domain_s: FC domain (aka fabric) objects
> - efc_node_s: FC node (aka remote ports) objects
>
> Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
>
> ---
> v3:
> Removed Sparse Vector APIs and structures.
> ---
> drivers/scsi/elx/libefc/efc.h | 72 +++++
> drivers/scsi/elx/libefc/efc_lib.c | 41 +++
> drivers/scsi/elx/libefc/efclib.h | 640 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 753 insertions(+)
> create mode 100644 drivers/scsi/elx/libefc/efc.h
> create mode 100644 drivers/scsi/elx/libefc/efc_lib.c
> create mode 100644 drivers/scsi/elx/libefc/efclib.h
>
[ .. ]
> +#define EFC_LOG_LIB 0x01
> +#define EFC_LOG_NODE 0x02
> +#define EFC_LOG_PORT 0x04
> +#define EFC_LOG_DOMAIN 0x08
> +#define EFC_LOG_ELS 0x10
> +#define EFC_LOG_DOMAIN_SM 0x20
> +#define EFC_LOG_SM 0x40
> +
> +/* efc library port structure */
> +struct efc {
> + void *base;
> + struct pci_dev *pcidev;
> + u64 req_wwpn;
> + u64 req_wwnn;
> +
> + u64 def_wwpn;
> + u64 def_wwnn;
> + u64 max_xfer_size;
> + u32 nodes_count;
> + mempool_t *node_pool;
> + struct dma_pool *node_dma_pool;
> +
> + u32 link_status;
> +

Maybe move 'nodes_count' after 'node_dma_pool' for better alignment?

But just a minor nit.

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer