Re: [PATCH v3 14/31] elx: libefc: FC node ELS and state handling

Nathan Chancellor
2020-04-23T08:12:20Z

On Thu, Apr 23, 2020 at 10:05:08AM +0200, Daniel Wagner wrote:
> Hi James,
>
> On Wed, Apr 22, 2020 at 07:50:06PM -0700, James Smart wrote:
> > On 4/15/2020 11:56 AM, Daniel Wagner wrote:
> > ...
> > > > + switch (evt) {
> > > > + case EFC_EVT_ENTER:
> > > > + efc_node_hold_frames(node);
> > > > + /* Fall through */
> > >
> > > fallthrough;
> > >
> >
> > Actually the patches that went in for -Wimplicit-fallthrough wants
> > /* fall through */
>
> Ah okay, I though the fall through rules are active. Anyway, I am sure
> someone will run a script to report when to change.
>
> Thanks,
> Daniel

Indeed, fallthrough; is preferred now, see commit f36d3eb89a43 ("checkpatch:
prefer fallthrough; over fallthrough comments") and the thread that is
linked in that commit.

Cheers,
Nathan