Re: [PATCH V2] scsi: put hot fields of scsi_host_template into one cacheline

Douglas Gilbert
2020-05-01T22:27:14Z

On 2020-04-22 5:54 a.m., Ming Lei wrote:
> The following three fields of scsi_host_template are referenced in
> scsi IO submission path, so put them together into one cacheline:
>
> - cmd_size
> - queuecommand
> - commit_rqs
>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: John Garry <john.garry@huawei.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> V2:
> - move the 3 fields at the beginning of scsi_host_template
> - comment why we do this way
>
> include/scsi/scsi_host.h | 72 ++++++++++++++++++++++------------------
> 1 file changed, 39 insertions(+), 33 deletions(-)

Hi,
I would like to test this patch. However it doesn't apply on Martin's
tree (all 3 chunks fail). Could you post a clean version?

Doug Gilbert