From: Dan Carpenter <dan.carpenter@oracle.com>
To: suganath-prabu.subramani@broadcom.com
Cc: MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: Re: [bug report] scsi: mpt3sas: Handle RDPQ DMA allocation in same 4G region
Date: Fri, 1 May 2020 12:53:11 +0300 [thread overview]
Message-ID: <20200501095311.GD1992@kadam> (raw)
In-Reply-To: <20200429142149.GA823478@mwanda>
This also causes a bug in the callers.
drivers/scsi/mpt3sas/mpt3sas_base.c:7428 mpt3sas_base_attach()
warn: 'ioc->hpr_lookup' double freed
We free the pointers, then return an error and the caller frees the
pointers as well.
Smatch is very limited in the types of double frees it looks for.
It really requires someone to manually go through the free paths and
check it by hand because I'm sure there are other bugs there as well.
Please CC me on the Fix because I'm not subscribed to the linux-scsi
mailing list.
regards,
dan carpenter
next prev parent reply other threads:[~2020-05-01 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 14:21 [bug report] scsi: mpt3sas: Handle RDPQ DMA allocation in same 4G region Dan Carpenter
2020-05-01 9:53 ` Dan Carpenter [this message]
2020-05-04 11:39 ` Suganath Prabu Subramani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501095311.GD1992@kadam \
--to=dan.carpenter@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).