Re: [PATCH 6/9] lpfc: Remove unnecessary lockdep_assert_held calls

Hannes Reinecke
2020-05-07T09:50:08Z

On 5/1/20 11:43 PM, James Smart wrote:
> In an audit of lockdep calls in the driver, there are multiple lockdep
> checks in successive calling layers. E.g. a routine checks, and then
> calls a lower routine that also checks, and so on. Calling sequences
> result in many redundant checks.
>
> Refine the code to remove lower-level lockdep checks.
> Update comments on the lock, correcting a few places where lock object
> in comment was incorrect.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_hbadisc.c | 8 +++-----
> drivers/scsi/lpfc/lpfc_sli.c | 33 +++++++++++++++-----------------
> 2 files changed, 18 insertions(+), 23 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer