Re: [PATCH] qla2xxx: Remove return value from qla_nvme_ls()

[Roman Bolshakov <r.bolshakov@yadro.com>]

On Wed, May 20, 2020 at 03:08:19PM +0200, Daniel Wagner wrote:
> The function always returns QLA_SUCCESS and the caller
> qla2x00_start_sp() doesn't even evalute the return value. So there is
> no point in returning a status.
> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  drivers/scsi/qla2xxx/qla_iocb.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> index b039bd83f947..8865c35d3421 100644
> --- a/drivers/scsi/qla2xxx/qla_iocb.c
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
> @@ -3607,11 +3607,10 @@ static void qla2x00_send_notify_ack_iocb(srb_t *sp,
>  /*
>   * Build NVME LS request
>   */
> -static int
> +static void
>  qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt)
>  {
>  	struct srb_iocb *nvme;
> -	int     rval = QLA_SUCCESS;
>  
>  	nvme = &sp->u.iocb_cmd;
>  	cmd_pkt->entry_type = PT_LS4_REQUEST;
> @@ -3631,8 +3630,6 @@ qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt)
>  	cmd_pkt->rx_byte_count = cpu_to_le32(nvme->u.nvme.rsp_len);
>  	cmd_pkt->dsd[1].length = cpu_to_le32(nvme->u.nvme.rsp_len);
>  	put_unaligned_le64(nvme->u.nvme.rsp_dma, &cmd_pkt->dsd[1].address);
> -
> -	return rval;
>  }
>  
>  static void
> -- 
> 2.16.4
> 

Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>

Thanks,
Roman