From: Chuhong Yuan <hslester96@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Chris Boot <bootc@bootc.net>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chuhong Yuan <hslester96@gmail.com>
Subject: [PATCH] sbp-target: add the missed kfree() in an error path
Date: Thu, 28 May 2020 18:20:56 +0800 [thread overview]
Message-ID: <20200528102056.911825-1-hslester96@gmail.com> (raw)
sbp_fetch_command() forgets to call kfree() in an error path.
Add the missed call to fix it.
Fixes: a511ce339780 ("sbp-target: Initial merge of firewire/ieee-1394 target mode support")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/target/sbp/sbp_target.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index e4a9b9fe3dfb..504a755ea344 100644
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -1128,8 +1128,10 @@ static int sbp_fetch_command(struct sbp_target_request *req)
req->orb_pointer + sizeof(req->orb),
req->cmd_buf + sizeof(req->orb.command_block),
copy_len);
- if (ret != RCODE_COMPLETE)
+ if (ret != RCODE_COMPLETE) {
+ kfree(req->cmd_buf);
return -EIO;
+ }
}
return 0;
--
2.26.2
next reply other threads:[~2020-05-28 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 10:20 Chuhong Yuan [this message]
2020-05-28 14:53 ` [PATCH] sbp-target: add the missed kfree() in an error path Bart Van Assche
2020-05-28 15:16 ` Chris Boot
2020-06-03 1:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528102056.911825-1-hslester96@gmail.com \
--to=hslester96@gmail.com \
--cc=bootc@bootc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox