From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Doug Gilbert <dgilbert@interlog.com>,
Daniel Wagner <daniel.wagner@suse.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv4 0/6] scsi: use xarray for devices and targets
Date: Tue, 2 Jun 2020 13:33:05 +0200 [thread overview]
Message-ID: <20200602113311.121513-1-hare@suse.de> (raw)
Hi all,
based on the ideas from Doug Gilbert here's now my take on using
xarrays for devices and targets.
It revolves around two ideas:
- The scsi target 'channel' and 'id' numbers are never ever used
to the full 32 bit range; channels are well below 10, and no
driver is using more than 16 bits for the id. So we can reduce
the type of 'channel' and 'id' to 16 bits, and use the 32 bit
value 'channel << 16 | id' as the index into the target xarray.
- Nearly every target only ever uses the first two levels of the
4-level SCSI LUN structure, which means that we can use the
linearized SCSI LUN id as an index into the xarray.
If we ever come across targets utilizing more that 2 levels of
the LUN structure we'll allocate the first unused index and have
to resort to a less efficient lookup instead of direct indexing.
With these changes we can implement an efficient lookup mechanism,
devolving into direct lookup for most cases. It also allows us to
detect duplicate entries or accidental overwrites of existing elements
by using xa_cmpxchg().
And iteration over targets and devices should be as efficient as the
current, list-based, approach.
As usual, comments and reviews are welcome.
Changes to v2:
- Implement safe device iteration as noted by Doug
- Add an additional patch to avoid a pointless memory allocation
in scsi_alloc_target()
Hannes Reinecke (6):
scsi: convert target lookup to xarray
target_core_pscsi: use __scsi_device_lookup()
scsi: move target device list to xarray
scsi: remove direct device lookup per host
scsi_error: use xarray lookup instead of wrappers
scsi: avoid pointless memory allocation in scsi_alloc_target()
drivers/scsi/hosts.c | 5 +-
drivers/scsi/scsi.c | 151 +++++++++++++++++++++++++++++--------
drivers/scsi/scsi_error.c | 35 +++++----
drivers/scsi/scsi_lib.c | 9 +--
drivers/scsi/scsi_priv.h | 2 +
drivers/scsi/scsi_scan.c | 101 +++++++++++++++----------
drivers/scsi/scsi_sysfs.c | 72 +++++++++++++-----
drivers/target/target_core_pscsi.c | 8 +-
include/scsi/scsi_device.h | 32 +++++---
include/scsi/scsi_host.h | 5 +-
10 files changed, 288 insertions(+), 132 deletions(-)
--
2.16.4
next reply other threads:[~2020-06-02 11:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 11:33 Hannes Reinecke [this message]
2020-06-02 11:33 ` [PATCH 1/6] scsi: convert target lookup to xarray Hannes Reinecke
2020-06-02 11:33 ` [PATCH 2/6] target_core_pscsi: use __scsi_device_lookup() Hannes Reinecke
2020-06-02 11:33 ` [PATCH 3/6] scsi: move target device list to xarray Hannes Reinecke
2020-06-02 11:33 ` [PATCH 4/6] scsi: remove direct device lookup per host Hannes Reinecke
2020-06-02 11:33 ` [PATCH 5/6] scsi_error: use xarray lookup instead of wrappers Hannes Reinecke
2020-06-02 11:33 ` [PATCH 6/6] scsi: avoid pointless memory allocation in scsi_alloc_target() Hannes Reinecke
2020-06-03 12:53 ` [PATCHv4 0/6] scsi: use xarray for devices and targets Christoph Hellwig
2020-06-03 18:23 ` Douglas Gilbert
2020-06-04 16:12 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602113311.121513-1-hare@suse.de \
--to=hare@suse.de \
--cc=daniel.wagner@suse.com \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox