Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Kai Liu <kai.liu@suse.com>
To: <xiakaixu1987@gmail.com>
Cc: <kashyap.desai@broadcom.com>, <sumit.saxena@broadcom.com>,
	<shivasharan.srikanteshwara@broadcom.com>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Xiaoming Gao <newtongao@tencent.com>
Subject: Re: [PATCH] scsi: megaraid_sas: fix kdump kernel boot hung caused by JBOD
Date: Tue, 2 Jun 2020 20:12:25 +0800	[thread overview]
Message-ID: <20200602121225.okhqr2xitv6522pp@suse.com> (raw)
In-Reply-To: <1590651115-9619-1-git-send-email-newtongao@tencent.com>

On 2020/05/28 Thu 15:31, xiakaixu1987@gmail.com wrote:
>From: Xiaoming Gao <newtongao@tencent.com>
>
>when kernel crash, and kexec into kdump kernel, megaraid_sas will hung and
>print follow error logs
>
>24.1485901 sd 0:0:G:0: [sda 1 tag809 BRCfl Debug mfi stat 0x2(1, data len requested/conpleted 0X100
>0/0x0)]
>24.1867171 sd 0:0:G :9: [sda I tag861 BRCfl Debug mfft stat 0x2d, data len reques ted/conp1e Led 0X100
>0/0x0]
>24.2054191 sd 0:O:6:O: [sda 1 tag861 FAILED Result: hustbyte=DIDGK drioerbyte-DRIUCR SENSE]
>24.2549711 bik_update_ request ! 1/0 error , dev sda, sector 937782912 op 0x0:(READ) flags 0x0 phys_seg 1 prio class
>21.2752791 buffer_io_error 2 callbacks suppressed
>21.2752731 Duffer IO error an dev sda, logical block 117212064, async page read
>
>this bug is caused by commit '59db5a931bbe73f ("scsi: megaraid_sas: Handle sequence JBOD map failure at
> driver level
>")'
>and can be fixed by not set JOB when reset_devices on

I've recently run into this exact issue on a arm64 machine with Avago 
3408 controller. This patch fixed the issue. Thank you.

Tested-by: Kai Liu <kai.liu@suse.com>

Best regards,
Kai

>
>Signed-off-by: Xiaoming Gao <newtongao@tencent.com>
>---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>index b2ad965..24e7f1b 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
>@@ -3127,7 +3127,7 @@ static void megasas_build_ld_nonrw_fusion(struct megasas_instance *instance,
> 		<< MR_RAID_CTX_RAID_FLAGS_IO_SUB_TYPE_SHIFT;
>
> 	/* If FW supports PD sequence number */
>-	if (instance->support_seqnum_jbod_fp) {
>+	if (!reset_devices && instance->support_seqnum_jbod_fp) {
> 		if (instance->use_seqnum_jbod_fp &&
> 			instance->pd_list[pd_index].driveType == TYPE_DISK) {
>
>-- 
>1.8.3.1
>


  reply	other threads:[~2020-06-02 12:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  7:31 [PATCH] scsi: megaraid_sas: fix kdump kernel boot hung caused by JBOD xiakaixu1987
2020-06-02 12:12 ` Kai Liu [this message]
2020-06-03  1:31 ` Martin K. Petersen
2020-06-03 13:34   ` Chandrakanth Patil
2020-06-04 11:09   ` Chandrakanth Patil
2020-06-04 15:50     ` Kai Liu
2020-06-04 19:35       ` Chandrakanth Patil
2020-06-05  4:38         ` Kai Liu
2020-06-05 15:30           ` Chandrakanth Patil
2020-06-06  4:50             ` Kai Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602121225.okhqr2xitv6522pp@suse.com \
    --to=kai.liu@suse.com \
    --cc=jejb@linux.ibm.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=newtongao@tencent.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=xiakaixu1987@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox