From: kernel test robot <lkp@intel.com>
To: Mike Christie <michael.christie@oracle.com>,
bvanassche@acm.org, bstroesser@ts.fujitsu.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH 12/17] target: hook most target users into sysfs API
Date: Mon, 8 Jun 2020 18:20:30 +0800 [thread overview]
Message-ID: <202006081827.YEB3tIoU%lkp@intel.com> (raw)
In-Reply-To: <1591562164-9766-13-git-send-email-michael.christie@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 6535 bytes --]
Hi Mike,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next vhost/linux-next xen-tip/linux-next v5.7 next-20200605]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mike-Christie/target-add-sysfs-support/20200608-044027
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Note: the linux-review/Mike-Christie/target-add-sysfs-support/20200608-044027 HEAD fc08cd1eb111346ece0dceae6f01be21509d2c49 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/target/target_core_sysfs.c: In function 'target_cp_endpoint_strs':
>> drivers/target/target_core_sysfs.c:172:13: error: 'struct se_session' has no member named 'tfo'
172 | if (se_sess->tfo->fabric_alias)
| ^~
drivers/target/target_core_sysfs.c:173:41: error: 'struct se_session' has no member named 'tfo'
173 | se_sess->fabric_name = kstrdup(se_sess->tfo->fabric_alias,
| ^~
drivers/target/target_core_sysfs.c:176:41: error: 'struct se_session' has no member named 'tfo'
176 | se_sess->fabric_name = kstrdup(se_sess->tfo->fabric_name,
| ^~
drivers/target/target_core_sysfs.c: In function 'target_sysfs_add_session':
drivers/target/target_core_sysfs.c:206:29: error: 'struct se_session' has no member named 'tfo'
206 | if (!try_module_get(se_sess->tfo->module))
| ^~
drivers/target/target_core_sysfs.c:213:31: error: 'struct se_session' has no member named 'tfo'
213 | se_sess->dev.groups = se_sess->tfo->session_attr_groups;
| ^~
drivers/target/target_core_sysfs.c:233:20: error: 'struct se_session' has no member named 'tfo'
233 | module_put(se_sess->tfo->module);
| ^~
vim +172 drivers/target/target_core_sysfs.c
03975f2939ad69 Mike Christie 2020-06-07 151
03975f2939ad69 Mike Christie 2020-06-07 152 static int target_cp_endpoint_strs(struct se_portal_group *se_tpg,
03975f2939ad69 Mike Christie 2020-06-07 153 struct se_session *se_sess)
03975f2939ad69 Mike Christie 2020-06-07 154 {
03975f2939ad69 Mike Christie 2020-06-07 155 /*
03975f2939ad69 Mike Christie 2020-06-07 156 * Copy configfs dir/object names so userspace can match the session
03975f2939ad69 Mike Christie 2020-06-07 157 * to its target, and we also don't have to worry about mixing configfs
03975f2939ad69 Mike Christie 2020-06-07 158 * refcounts with sysfs.
03975f2939ad69 Mike Christie 2020-06-07 159 */
03975f2939ad69 Mike Christie 2020-06-07 160 if (!se_sess->se_node_acl->dynamic_node_acl) {
03975f2939ad69 Mike Christie 2020-06-07 161 se_sess->acl_name = kstrdup(se_sess->se_node_acl->initiatorname,
03975f2939ad69 Mike Christie 2020-06-07 162 GFP_KERNEL);
03975f2939ad69 Mike Christie 2020-06-07 163 if (!se_sess->acl_name)
03975f2939ad69 Mike Christie 2020-06-07 164 return -ENOMEM;
03975f2939ad69 Mike Christie 2020-06-07 165 }
03975f2939ad69 Mike Christie 2020-06-07 166
03975f2939ad69 Mike Christie 2020-06-07 167 se_sess->target_name = kstrdup(se_tpg->se_tpg_wwn->wwn_group.cg_item.ci_name,
03975f2939ad69 Mike Christie 2020-06-07 168 GFP_KERNEL);
03975f2939ad69 Mike Christie 2020-06-07 169 if (!se_sess->target_name)
03975f2939ad69 Mike Christie 2020-06-07 170 goto free_acl;
03975f2939ad69 Mike Christie 2020-06-07 171
03975f2939ad69 Mike Christie 2020-06-07 @172 if (se_sess->tfo->fabric_alias)
03975f2939ad69 Mike Christie 2020-06-07 173 se_sess->fabric_name = kstrdup(se_sess->tfo->fabric_alias,
03975f2939ad69 Mike Christie 2020-06-07 174 GFP_KERNEL);
03975f2939ad69 Mike Christie 2020-06-07 175 else
03975f2939ad69 Mike Christie 2020-06-07 176 se_sess->fabric_name = kstrdup(se_sess->tfo->fabric_name,
03975f2939ad69 Mike Christie 2020-06-07 177 GFP_KERNEL);
03975f2939ad69 Mike Christie 2020-06-07 178 if (!se_sess->fabric_name)
03975f2939ad69 Mike Christie 2020-06-07 179 goto free_target;
03975f2939ad69 Mike Christie 2020-06-07 180
03975f2939ad69 Mike Christie 2020-06-07 181 se_sess->tpg_name = kstrdup(se_tpg->tpg_group.cg_item.ci_name,
03975f2939ad69 Mike Christie 2020-06-07 182 GFP_KERNEL);
03975f2939ad69 Mike Christie 2020-06-07 183 if (!se_sess->tpg_name)
03975f2939ad69 Mike Christie 2020-06-07 184 goto free_fabric;
03975f2939ad69 Mike Christie 2020-06-07 185
03975f2939ad69 Mike Christie 2020-06-07 186 return 0;
03975f2939ad69 Mike Christie 2020-06-07 187
03975f2939ad69 Mike Christie 2020-06-07 188 free_fabric:
03975f2939ad69 Mike Christie 2020-06-07 189 kfree(se_sess->fabric_name);
03975f2939ad69 Mike Christie 2020-06-07 190 se_sess->fabric_name = NULL;
03975f2939ad69 Mike Christie 2020-06-07 191 free_target:
03975f2939ad69 Mike Christie 2020-06-07 192 kfree(se_sess->target_name);
03975f2939ad69 Mike Christie 2020-06-07 193 se_sess->target_name = NULL;
03975f2939ad69 Mike Christie 2020-06-07 194 free_acl:
03975f2939ad69 Mike Christie 2020-06-07 195 kfree(se_sess->acl_name);
03975f2939ad69 Mike Christie 2020-06-07 196 se_sess->acl_name = NULL;
03975f2939ad69 Mike Christie 2020-06-07 197 return -ENOMEM;
03975f2939ad69 Mike Christie 2020-06-07 198 }
03975f2939ad69 Mike Christie 2020-06-07 199
:::::: The code at line 172 was first introduced by commit
:::::: 03975f2939ad69a19b1a7cdd49cb83e66258688e target: add session sysfs class support
:::::: TO: Mike Christie <michael.christie@oracle.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62562 bytes --]
next prev parent reply other threads:[~2020-06-08 10:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 20:35 [PATCH v6 00/17] target: add sysfs support Mike Christie
2020-06-07 20:35 ` [PATCH 01/17] target: check enforce_pr_isids during registration Mike Christie
2020-06-07 20:35 ` [PATCH 02/17] target: separate acl name from port ids Mike Christie
2020-06-09 10:11 ` Stefan Hajnoczi
2020-06-09 14:13 ` Himanshu Madhani
2020-06-07 20:35 ` [PATCH 03/17] target: add helper to parse acl and transport name Mike Christie
2020-06-07 20:35 ` [PATCH 04/17] tcm loop: use target_parse_emulated_name Mike Christie
2020-06-07 20:35 ` [PATCH 05/17] vhost scsi: " Mike Christie
2020-06-09 10:21 ` Stefan Hajnoczi
2020-06-07 20:35 ` [PATCH 06/17] xen scsiback: " Mike Christie
2020-06-07 20:35 ` [PATCH 07/17] iscsi target: setup transport_id Mike Christie
2020-06-07 20:35 ` [PATCH 08/17] target: use tpt_id in target_stat_iport_port_ident_show Mike Christie
2020-06-07 20:35 ` [PATCH 09/17] target: drop sess_get_initiator_sid from PR code Mike Christie
2020-06-07 20:35 ` [PATCH 10/17] target: drop sess_get_initiator_sid Mike Christie
2020-06-07 20:35 ` [PATCH 11/17] target: add session sysfs class support Mike Christie
2020-06-08 5:32 ` Greg Kroah-Hartman
2020-06-08 15:35 ` Mike Christie
2020-06-08 16:36 ` Greg Kroah-Hartman
2020-06-08 19:02 ` Mike Christie
2020-06-09 6:05 ` Greg Kroah-Hartman
2020-06-08 6:14 ` Hannes Reinecke
2020-06-08 15:21 ` Mike Christie
2020-06-08 15:55 ` Michael Christie
2020-06-09 3:10 ` Michael Christie
2020-06-08 12:06 ` Bodo Stroesser
2020-06-08 14:49 ` Mike Christie
2020-06-08 12:18 ` Greg Kroah-Hartman
2020-06-08 12:18 ` Greg Kroah-Hartman
2020-06-07 20:35 ` [PATCH 12/17] target: hook most target users into sysfs API Mike Christie
2020-06-08 6:15 ` Hannes Reinecke
2020-06-08 10:20 ` kernel test robot [this message]
2020-06-07 20:36 ` [PATCH 13/17] iscsi target: replace module sids with lio's sid Mike Christie
2020-06-08 6:16 ` Hannes Reinecke
2020-06-07 20:36 ` [PATCH 14/17] target: add free_session callout Mike Christie
2020-06-08 6:19 ` Hannes Reinecke
2020-06-07 20:36 ` [PATCH 15/17] iscsi target: hook iscsi target into sysfs API Mike Christie
2020-06-08 6:20 ` Hannes Reinecke
2020-06-07 20:36 ` [PATCH 16/17] iscsi target: export session state and alias in sysfs Mike Christie
2020-06-08 6:21 ` Hannes Reinecke
2020-06-07 20:36 ` [PATCH 17/17] target: drop sess_get_index Mike Christie
2020-06-08 6:21 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006081827.YEB3tIoU%lkp@intel.com \
--to=lkp@intel.com \
--cc=bstroesser@ts.fujitsu.com \
--cc=bvanassche@acm.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox