Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3] scsi: ufs: UFS crypto API
Date: Wed, 17 Jun 2020 09:27:16 -0700	[thread overview]
Message-ID: <20200617162716.GC1138@sol.localdomain> (raw)
In-Reply-To: <20200617081841.218985-3-satyat@google.com>

On Wed, Jun 17, 2020 at 08:18:40AM +0000, Satya Tangirala wrote:
> Introduce functions to manipulate UFS inline encryption hardware
> in line with the JEDEC UFSHCI v2.1 specification and to work with the
> block keyslot manager.
> 
> The UFS crypto API will assume by default that a vendor driver doesn't
> support UFS crypto, even if the hardware advertises the capability, because
> a lot of hardware requires some special handling that's not specified in
> the aforementioned JEDEC spec. Each vendor driver must explicity set
> hba->caps |= UFSHCD_CAP_CRYPTO before ufshcd_hba_init_crypto is called to
> opt-in to UFS crypto support.
> 
> Signed-off-by: Satya Tangirala <satyat@google.com>
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Stanley Chu had made a comment and provided Reviewed-by at
https://lkml.kernel.org/linux-scsi/1589524526.3197.110.camel@mtkswgap22.
Looks like that was missed?

- Eric

  reply	other threads:[~2020-06-17 16:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  8:18 [PATCH 0/3] Inline Encryption Support for UFS Satya Tangirala
2020-06-17  8:18 ` [PATCH 1/3] scsi: ufs: UFS driver v2.1 spec crypto additions Satya Tangirala
2020-06-17 16:26   ` Eric Biggers
2020-06-17  8:18 ` [PATCH 2/3] scsi: ufs: UFS crypto API Satya Tangirala
2020-06-17 16:27   ` Eric Biggers [this message]
2020-06-17  8:18 ` [PATCH 3/3] scsi: ufs: Add inline encryption support to UFS Satya Tangirala
2020-06-17 16:28   ` Eric Biggers
2020-06-18  2:52     ` Satya Tangirala
2020-06-17 16:24 ` [PATCH 0/3] Inline Encryption Support for UFS Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617162716.GC1138@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=satyat@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox