Re: [PATCH v1 1/2] ufs: support various values per device

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2538 bytes --]

Hi Kiwoong,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next v5.8-rc3 next-20200701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kiwoong-Kim/ufs-support-various-values-per-device/20200702-102146
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/ufs/ufshcd.c:6951:6: warning: no previous prototype for 'ufshcd_set_dev_values' [-Wmissing-prototypes]
    6951 | void ufshcd_set_dev_values(struct ufs_hba *hba, struct ufs_dev_value *value)
         |      ^~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/ufs/ufshcd.c: In function 'ufs_fixup_device_setup':
>> drivers/scsi/ufs/ufshcd.c:6978:29: warning: passing argument 2 of 'ufshcd_set_dev_values' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    6978 |  ufshcd_set_dev_values(hba, ufs_dev_values);
         |                             ^~~~~~~~~~~~~~
   drivers/scsi/ufs/ufshcd.c:6951:71: note: expected 'struct ufs_dev_value *' but argument is of type 'const struct ufs_dev_value *'
    6951 | void ufshcd_set_dev_values(struct ufs_hba *hba, struct ufs_dev_value *value)
         |                                                 ~~~~~~~~~~~~~~~~~~~~~~^~~~~

vim +6978 drivers/scsi/ufs/ufshcd.c

  6971	
  6972	static void ufs_fixup_device_setup(struct ufs_hba *hba)
  6973	{
  6974		/* fix by general quirk table */
  6975		ufshcd_fixup_dev_quirks(hba, ufs_fixups);
  6976	
  6977		/* set device specific values */
> 6978		ufshcd_set_dev_values(hba, ufs_dev_values);
  6979	
  6980		/* allow vendors to fix quirks */
  6981		ufshcd_vops_fixup_dev_quirks(hba);
  6982	}
  6983	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67090 bytes --]