From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BEEC433E5 for ; Mon, 13 Jul 2020 16:13:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B363D20738 for ; Mon, 13 Jul 2020 16:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730188AbgGMQNr (ORCPT ); Mon, 13 Jul 2020 12:13:47 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:40425 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729027AbgGMQNq (ORCPT ); Mon, 13 Jul 2020 12:13:46 -0400 Received: from localhost (varun.asicdesigners.com [10.193.191.116]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 06DGDc06003726; Mon, 13 Jul 2020 09:13:38 -0700 Date: Mon, 13 Jul 2020 21:43:37 +0530 From: Varun Prakash To: Dan Carpenter Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Pankaj Bharadiya , Austin Kim , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, varun@chelsio.com Subject: Re: [PATCH] scsi: cxgb4i: clean up a debug printk Message-ID: <20200713161336.GA1780@chelsio.com> References: <20200713105100.GA251988@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713105100.GA251988@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Mon, Jul 13, 2020 at 10:51:00AM +0000, Dan Carpenter wrote: > The pr_fmt() at the top of the file already includes the __func__ so we > can remove the duplicative "cxgbi_conn_init_pdu:" from the string here. > Now it all fits on one line as well. > > Signed-off-by: Dan Carpenter > --- > drivers/scsi/cxgbi/libcxgbi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > index 1fb101c616b7..ba1593be626c 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -2182,8 +2182,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset, > } > > log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX, > - "cxgbi_conn_init_pdu: tdata->total_count %u, " > - "tdata->total_offset %u\n", > + "data->total_count %u, tdata->total_offset %u\n", > tdata->total_count, tdata->total_offset); > > expected_count = tdata->total_count; Acked-by: Varun Prakash