From: Benjamin Block <bblock@linux.ibm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Steffen Maier <maier@linux.ibm.com>,
Julian Wiedmann <jwi@linux.ibm.com>,
Fedor Loshakov <loshakov@linux.ibm.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] scsi: Rename slave_configure to sdev_configure
Date: Tue, 14 Jul 2020 14:02:42 +0200 [thread overview]
Message-ID: <20200714120242.GC7244@t480-pf1aa2c2> (raw)
In-Reply-To: <20200714114122.GA12769@casper.infradead.org>
On Tue, Jul 14, 2020 at 12:41:22PM +0100, Matthew Wilcox wrote:
> On Tue, Jul 14, 2020 at 10:26:31AM +0200, Benjamin Block wrote:
> > > @@ -428,7 +428,7 @@ static struct scsi_host_template zfcp_scsi_host_template = {
> > > .eh_target_reset_handler = zfcp_scsi_eh_target_reset_handler,
> > > .eh_host_reset_handler = zfcp_scsi_eh_host_reset_handler,
> > > .sdev_prep = zfcp_scsi_sdev_prep,
> > > - .slave_configure = zfcp_scsi_slave_configure,
> > > + .sdev_configure = zfcp_scsi_sdev_configure,
> >
> > Please fix the alignment.
>
> sed doesn't kow how to do that.
So? We have been able to maintain it so far without sed being able to do
it.
I don't mean to be snarky or anything, but I don't see why we can't have
this respect the code-base we have so far.
--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
prev parent reply other threads:[~2020-07-14 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 19:39 [PATCH 0/3] Rename some scsi host template functions Matthew Wilcox (Oracle)
2020-07-06 19:39 ` [PATCH 1/3] scsi: Rename slave_alloc to sdev_prep Matthew Wilcox (Oracle)
2020-07-06 19:39 ` [PATCH 2/3] scsi: Rename slave_destroy to sdev_destroy Matthew Wilcox (Oracle)
2020-07-06 19:39 ` [PATCH 3/3] scsi: Rename slave_configure to sdev_configure Matthew Wilcox (Oracle)
2020-07-07 7:58 ` Johannes Thumshirn
2020-07-14 8:26 ` Benjamin Block
2020-07-14 11:41 ` Matthew Wilcox
2020-07-14 12:02 ` Benjamin Block [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714120242.GC7244@t480-pf1aa2c2 \
--to=bblock@linux.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=jwi@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=loshakov@linux.ibm.com \
--cc=maier@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox