From: Andrew Lunn <andrew@lunn.ch>
To: Alexander Lobakin <alobakin@marvell.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Igor Russkikh <irusskikh@marvell.com>,
Michal Kalderon <michal.kalderon@marvell.com>,
Ariel Elior <aelior@marvell.com>,
Denis Bolotin <denis.bolotin@marvell.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
GR-everest-linux-l2@marvell.com,
QLogic-Storage-Upstream@marvell.com, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 01/14] qed: convert link mode from u32 to bitmap
Date: Sun, 19 Jul 2020 23:21:00 +0200 [thread overview]
Message-ID: <20200719212100.GM1383417@lunn.ch> (raw)
In-Reply-To: <20200719201453.3648-2-alobakin@marvell.com>
On Sun, Jul 19, 2020 at 11:14:40PM +0300, Alexander Lobakin wrote:
> Currently qed driver already ran out of 32 bits to store link modes,
> and this doesn't allow to add and support more speeds.
> Convert link mode to bitmap that will always have enough space for
> any number of speeds and modes.
Hi Alexander
Why not just throw away all these QED_LM_ defines and use the kernel
link modes? The fact you are changing the u32 to a bitmap suggests the
hardware does not use them.
Andrew
next prev parent reply other threads:[~2020-07-19 21:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 20:14 [PATCH v2 net-next 00/14] qed/qede: add support for new operating modes Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 01/14] qed: convert link mode from u32 to bitmap Alexander Lobakin
2020-07-19 21:21 ` Andrew Lunn [this message]
2020-07-20 9:23 ` Alexander Lobakin
2020-07-20 15:19 ` Joe Perches
2020-07-20 15:29 ` Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 02/14] qed: reformat public_port::transceiver_data a bit Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 03/14] qed: add support for multi-rate transceivers Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 04/14] qed: use transceiver data to fill link partner's advertising speeds Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 05/14] qed: reformat several structures a bit Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 06/14] qed: add support for Forward Error Correction Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 07/14] qede: format qede{,_vf}_ethtool_ops Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 08/14] qede: introduce support for FEC control Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 09/14] qed: reformat several structures a bit Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 10/14] qed: remove unused qed_hw_info::port_mode and QED_PORT_MODE Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 11/14] qed: add support for new port modes Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 12/14] qed: add missing loopback modes Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 13/14] qed: populate supported link modes maps on module init Alexander Lobakin
2020-07-19 20:14 ` [PATCH v2 net-next 14/14] qed/qede: add support for the extended speed and FEC modes Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200719212100.GM1383417@lunn.ch \
--to=andrew@lunn.ch \
--cc=GR-everest-linux-l2@marvell.com \
--cc=QLogic-Storage-Upstream@marvell.com \
--cc=aelior@marvell.com \
--cc=alobakin@marvell.com \
--cc=davem@davemloft.net \
--cc=denis.bolotin@marvell.com \
--cc=irusskikh@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michal.kalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox