Re: [PATCH 01/10] block: introduce blk_is_valid_logical_block_size

Maxim Levitsky
2020-07-22T08:51:03Z

On Tue, 2020-07-21 at 17:13 +0200, Christoph Hellwig wrote:
> > +/**
> > + * blk_check_logical_block_size - check if logical block size is
> > supported
> > + * by the kernel
> > + * @size: the logical block size, in bytes
> > + *
> > + * Description:
> > + * This function checks if the block layers supports given block
> > size
> > + **/
> > +bool blk_is_valid_logical_block_size(unsigned int size)
> > +{
> > + return size >= SECTOR_SIZE && size <= PAGE_SIZE &&
> > !is_power_of_2(size);
>
> Shouldn't this be a ... && is_power_of_2(size)?
Yep. I noticed that few minutes after I sent the patches.

>
> > if (q->limits.io_min < q->limits.physical_block_size)
> > q->limits.io_min = q->limits.physical_block_size;
> > +
> > }
>
> This adds a pointless empty line.
Will fix.
>
> > +extern bool blk_is_valid_logical_block_size(unsigned int size);
>
> No need for externs on function declarations.
I also think so, but I followed the style of all existing function
prototypes in this file. Most of them have 'extern'.

Thanks for the review!

Best regards,
maxim Levitsky