Re: [PATCH 09/10] block: scsi: sd: use blk_is_valid_logical_block_size

Damien Le Moal
2020-07-21T11:25:20Z

On 2020/07/21 19:55, Maxim Levitsky wrote:
> Use blk_is_valid_logical_block_size instead of hardcoded list

s/hardcoded list/hardcoded checks./

>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> drivers/scsi/sd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index d90fefffe31b7..f012e7397b058 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -2520,10 +2520,7 @@ sd_read_capacity(struct scsi_disk *sdkp, unsigned char *buffer)
> "assuming 512.\n");
> }
>
> - if (sector_size != 512 &&
> - sector_size != 1024 &&
> - sector_size != 2048 &&
> - sector_size != 4096) {
> + if (!blk_is_valid_logical_block_size(sector_size)) {
> sd_printk(KERN_NOTICE, sdkp, "Unsupported sector size %d.\n",
> sector_size);
> /*
>

With the commit message fixed, looks OK.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

--
Damien Le Moal
Western Digital Research