public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jim Gill <jgill@vmware.com>
Cc: pv-drivers@vmware.com, jejb@ibm.linux.com,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/3 for-next] pvscsi: Limit ring pages for swiotlb
Date: Thu, 13 Aug 2020 08:26:55 +0100	[thread overview]
Message-ID: <20200813072655.GA14861@infradead.org> (raw)
In-Reply-To: <20200812205502.GA18382@petr-dev3.eng.vmware.com>

On Wed, Aug 12, 2020 at 01:55:02PM -0700, Jim Gill wrote:
> A large number of outstanding scsi commands can
>  completely fill up the allowable DMA size. Typically this happens with
>  SWIOTLB and SEV encryption active. While this is harmless for the scsi middle
>  layer, it floods the kernel log with error messages and can cause other
>  device drivers to error. Reduce the number of ring pages to 1 if we detect
>  DMA size restrictions.

Umm, no.  Drivers have absolutely no business checking
mem_encrypt_active().

      reply	other threads:[~2020-08-13  7:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 20:55 [PATCH 2/3 for-next] pvscsi: Limit ring pages for swiotlb Jim Gill
2020-08-13  7:26 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813072655.GA14861@infradead.org \
    --to=hch@infradead.org \
    --cc=jejb@ibm.linux.com \
    --cc=jgill@vmware.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pv-drivers@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox