From: Daniel Wagner <dwagner@suse.de>
To: Martin Wilck <mwilck@suse.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Nilesh Javali <njavali@marvell.com>
Subject: Re: [PATCH 4/4] qla2xxx: Handle incorrect entry_type entries
Date: Thu, 27 Aug 2020 13:46:26 +0200 [thread overview]
Message-ID: <20200827114626.daispydkcsdp3rj2@beryllium.lan> (raw)
In-Reply-To: <21cd86f782616fcac25f1a6270a9bd834ec777b7.camel@suse.com>
On Thu, Aug 27, 2020 at 12:17:13PM +0200, Martin Wilck wrote:
> Should we perhaps log an error message when we detect a mismatch
> between sp->type and entry_type?
Sure can do, but does it really help? Not much we can do in the
driver. I hope the firmware gets fixed eventually. I am not against it,
just not sure if the log entry really is helping except saying 'you are
using a firmware with a known issue'.
next prev parent reply other threads:[~2020-08-27 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 9:58 [PATCH 0/4] qla2xxx: A couple crash fixes Daniel Wagner
2020-08-27 9:58 ` [PATCH 1/4] qla2xxx: Reset done and free callback pointer on release Daniel Wagner
2020-08-27 10:12 ` Martin Wilck
2020-08-27 11:42 ` Daniel Wagner
2020-08-27 9:58 ` [PATCH 2/4] qla2xxx: Simplify return value logic in qla2x00_get_sp_from_handle() Daniel Wagner
2020-08-27 9:58 ` [PATCH 3/4] qla2xxx: Drop unused function argument from qla2x00_get_sp_from_handle() Daniel Wagner
2020-08-27 9:58 ` [PATCH 4/4] qla2xxx: Handle incorrect entry_type entries Daniel Wagner
2020-08-27 10:17 ` Martin Wilck
2020-08-27 11:46 ` Daniel Wagner [this message]
2020-08-27 12:45 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827114626.daispydkcsdp3rj2@beryllium.lan \
--to=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mwilck@suse.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox