Re: [PATCH 3/4] pm80xx : Increase the number of outstanding IO supported

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3646 bytes --]

Hi Viswas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.9-rc6 next-20200924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Viswas-G/pm80xx-updates/20200925-141508
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/417584937b14cc5369025f0d5cd9882674b8a2f8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Viswas-G/pm80xx-updates/20200925-141508
        git checkout 417584937b14cc5369025f0d5cd9882674b8a2f8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/pm8001/pm8001_init.c: In function 'pm8001_init_ccb_tag':
>> drivers/scsi/pm8001/pm8001_init.c:1174:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
    1174 |  int i, ret = 0;
         |         ^~~

vim +/ret +1174 drivers/scsi/pm8001/pm8001_init.c

  1164	
  1165	/*
  1166	 * pm8001_init_ccb_tag - allocate memory to CCB and tag.
  1167	 * @pm8001_ha: our hba card information.
  1168	 * @shost: scsi host which has been allocated outside.
  1169	 */
  1170	static int
  1171	pm8001_init_ccb_tag(struct pm8001_hba_info *pm8001_ha, struct Scsi_Host *shost,
  1172				struct pci_dev *pdev)
  1173	{
> 1174		int i, ret = 0;
  1175		u32 max_out_io, ccb_count;
  1176		u32 can_queue;
  1177	
  1178		max_out_io = pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_out_io;
  1179		ccb_count = min_t(int, PM8001_MAX_CCB, max_out_io);
  1180	
  1181		/*Update to the scsi host*/
  1182		can_queue = ccb_count - PM8001_RESERVE_SLOT;
  1183		shost->can_queue = can_queue;
  1184	
  1185		pm8001_ha->tags = kzalloc(ccb_count, GFP_KERNEL);
  1186		if (!pm8001_ha->tags)
  1187			goto err_out;
  1188	
  1189		/* Memory region for ccb_info*/
  1190		pm8001_ha->ccb_info = (struct pm8001_ccb_info *)
  1191			kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
  1192		if (!pm8001_ha->ccb_info) {
  1193			ret = -ENOMEM;
  1194			goto err_out_noccb;
  1195		}
  1196		for (i = 0; i < ccb_count; i++) {
  1197			pm8001_ha->ccb_info[i].buf_prd = pci_alloc_consistent(pdev,
  1198					sizeof(struct pm8001_prd) * PM8001_MAX_DMA_SG,
  1199					&pm8001_ha->ccb_info[i].ccb_dma_handle);
  1200			if (!pm8001_ha->ccb_info[i].buf_prd) {
  1201				PM8001_FAIL_DBG(pm8001_ha, pm8001_printk
  1202						(KERN_ERR "pm80xx: ccb prd memory allocation error\n"));
  1203				goto err_out;
  1204			}
  1205			pm8001_ha->ccb_info[i].task = NULL;
  1206			pm8001_ha->ccb_info[i].ccb_tag = 0xffffffff;
  1207			pm8001_ha->ccb_info[i].device = NULL;
  1208			++pm8001_ha->tags_num;
  1209		}
  1210		return 0;
  1211	
  1212	err_out_noccb:
  1213		kfree(pm8001_ha->devices);
  1214	err_out:
  1215		return -ENOMEM;
  1216	}
  1217	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65068 bytes --]