From: ebiggers@kernel.org
To: Pujin Shi <shipujin.t@gmail.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Satya Tangirala <satyat@google.com>,
Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
hankinsea@gmail.com
Subject: Re: [PATCH v2] scsi: ufs: fix missing brace warning for old compilers
Date: Fri, 2 Oct 2020 10:09:15 -0700 [thread overview]
Message-ID: <20201002170915.GA2119452@gmail.com> (raw)
In-Reply-To: <20201002063538.1250-1-shipujin.t@gmail.com>
On Fri, Oct 02, 2020 at 02:35:38PM +0800, Pujin Shi wrote:
> For older versions of gcc, the array = {0}; will cause warnings:
>
> drivers/scsi/ufs/ufshcd-crypto.c: In function 'ufshcd_crypto_keyslot_program':
> drivers/scsi/ufs/ufshcd-crypto.c:62:8: warning: missing braces around initializer [-Wmissing-braces]
> union ufs_crypto_cfg_entry cfg = { 0 };
> ^
> drivers/scsi/ufs/ufshcd-crypto.c:62:8: warning: (near initialization for 'cfg.reg_val') [-Wmissing-braces]
> drivers/scsi/ufs/ufshcd-crypto.c: In function 'ufshcd_clear_keyslot':
> drivers/scsi/ufs/ufshcd-crypto.c:103:8: warning: missing braces around initializer [-Wmissing-braces]
> union ufs_crypto_cfg_entry cfg = { 0 };
> ^
> 2 warnings generated
>
> Fixes: 70297a8ac7a7 ("scsi: ufs: UFS crypto API")
> Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
> ---
> drivers/scsi/ufs/ufshcd-crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd-crypto.c b/drivers/scsi/ufs/ufshcd-crypto.c
> index d2edbd960ebf..07310b12a5dc 100644
> --- a/drivers/scsi/ufs/ufshcd-crypto.c
> +++ b/drivers/scsi/ufs/ufshcd-crypto.c
> @@ -59,7 +59,7 @@ static int ufshcd_crypto_keyslot_program(struct blk_keyslot_manager *ksm,
> u8 data_unit_mask = key->crypto_cfg.data_unit_size / 512;
> int i;
> int cap_idx = -1;
> - union ufs_crypto_cfg_entry cfg = { 0 };
> + union ufs_crypto_cfg_entry cfg = {};
> int err;
>
> BUILD_BUG_ON(UFS_CRYPTO_KEY_SIZE_INVALID != 0);
> @@ -100,7 +100,7 @@ static int ufshcd_clear_keyslot(struct ufs_hba *hba, int slot)
> * Clear the crypto cfg on the device. Clearing CFGE
> * might not be sufficient, so just clear the entire cfg.
> */
> - union ufs_crypto_cfg_entry cfg = { 0 };
> + union ufs_crypto_cfg_entry cfg = {};
>
Looks good,
Reviewed-by: Eric Biggers <ebiggers@google.com>
next prev parent reply other threads:[~2020-10-02 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 6:35 [PATCH v2] scsi: ufs: fix missing brace warning for old compilers Pujin Shi
2020-10-02 17:09 ` ebiggers [this message]
2020-10-02 23:13 ` Martin K. Petersen
2020-10-07 3:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002170915.GA2119452@gmail.com \
--to=ebiggers@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=hankinsea@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satyat@google.com \
--cc=shipujin.t@gmail.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox